Java-6228 add pull request workflow #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
module-util uses Java 11 because it needs to target Java 9 for some features. I also updated one of the Telemetry SDK components to use Java 11 because I used the google java formatter v0.9 because I upgraded to Gradle 6. I forget which one I did. |
Contributor
|
module-util uses Java 11 because it needs to target Java 9 for some features. I also updated one of the Telemetry SDK components to use Java 11 because I used the google java formatter v0.9 because I upgraded to Gradle 6. I forget which one I did. Also - no need to quote the Jira ticket here. |
breedx-nr
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy and paste. However, I did change the Java version to 11, to match the other workflows.
I've noticed some of our other open repos use Java 8 while others use Java 11. Just wanted to call that out.