Support for OpenTracing 0.33.0 #29
Conversation
|
Hi @agarbutt , Thanks for the contribution! I'm going to take a look at this. |
jeffalder
left a comment
jeffalder
left a comment
There was a problem hiding this comment.
1 - please ensure the license header is present on all added files
2 - check the use of AtomicBoolean
looks good otherwise.
| .optionallyWithTag( | ||
| "aws.lambda.eventSource.arn", EventSourceParser.parseEventSourceArn(input)) | ||
| .optionallyWithTag( | ||
| "aws.lambda.coldStart", TracingRequestHandler.isColdStart.getAndSet(false)) |
There was a problem hiding this comment.
This is the only isColdStart referenced any longer. Should it simply be an static AtomicBoolean on this class?
There was a problem hiding this comment.
Great catch! This is a bad refactoring. See my updated commit.
|
We should also update the AWS Lambda Tracer to support OpenTracing 0.33 in conjunction with this PR for the SDK. https://newrelic.atlassian.net/browse/JAVA-5898 |
- Corrected a bad refactoring referencing `isColdStart` - Added Copyright headers.
|
Thanks for the feedback @jeffalder. I believe I have addressed the concerns you raised. I'd be happy to help contribute, if that would be helpful, @jasonjkeller |
|
We'll have to ship an update to the other side of this to match up OT versions. |
3 participants
Support for #18