Addresses GitHub Issue #26 - Removes the json-simple dependency.
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Garbutt <[email protected]>
|
|
jasonjkeller
reviewed
Apr 2, 2020
Contributor
jasonjkeller
left a comment
jasonjkeller
left a comment
There was a problem hiding this comment.
If this truly isn't being used then 👍. I don't recall exactly why that dependency was originally added. Have you tested this in a live environment and verified that JSON payload is still generated in the Cloudwatch logs correctly?
Contributor
Author
|
Yeah, this library does not have a dependency on this library. |
jeffalder
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Garbutt [email protected]