Skip to content

Addresses GitHub Issue #24 - Implements support for APIGatewayV2 Events. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2020
Merged

Addresses GitHub Issue #24 - Implements support for APIGatewayV2 Events. #25

merged 2 commits into from
Apr 6, 2020

Conversation

@agarbutt
Copy link
Contributor

@agarbutt agarbutt commented Mar 31, 2020

Signed-off-by: Andrew Garbutt [email protected]

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jasonjkeller
jasonjkeller approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@jasonjkeller jasonjkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agarbutt These changes look good to me. Thanks for adding them! Please make sure to sign the CLA so that we can get these merged. Cheers

@agarbutt
Copy link
Contributor Author

agarbutt commented Apr 2, 2020

@jasonjkeller I am working on the CLA. My employer has a contract with New Relic and I want to make sure that we sign the correct CLA.

When i attempted to email [email protected] asking a question, it was bounced.
Can you help with this? Or should i open a support ticket? or?

@agarbutt
Copy link
Contributor Author

agarbutt commented Apr 4, 2020 •
edited
Loading

I have signed the CLA as an individual for now.
I have also updated the PR with changes to test the response.
Please re-review.

@agarbutt agarbutt requested a review from jasonjkeller April 4, 2020 16:32
@jeffalder
Copy link
Contributor

jeffalder commented Apr 6, 2020

Thanks @agarbutt ! I'll merge this, but please be aware that there is internal push to adjust how we do event source tagging, so there's a possibility it could change in the future.

@jeffalder jeffalder merged commit 236ea52 into newrelic:master Apr 6, 2020
@jeffalder jeffalder mentioned this pull request Apr 6, 2020
Closed
@agarbutt agarbutt deleted the APIGatewayV2Proxy-Events branch April 7, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonjkeller jasonjkeller Awaiting requested review from jasonjkeller

1 more reviewer

@jeffalder jeffalder jeffalder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agarbutt @CLAassistant @jeffalder @jasonjkeller