`@netlify/functions` type checking error with `skipLibCheck` turned off

[teemingc]

When importing a type from the @netlify/functions package, TypeScript complains about the @netlify/node-cookies module not being found.

~/git/sveltejs/kit/packages/adapter-netlify fix-types*
❯ pnpm check

> @sveltejs/adapter-netlify@5.0.2 check /home/chewteeming/git/sveltejs/kit/packages/adapter-netlify
> tsc

../../node_modules/.pnpm/@netlify+serverless-functions-api@2.1.1/node_modules/@netlify/serverless-functions-api/dist/cookie_store.d.ts:1:24 - error TS2307: Cannot find module '@netlify/node-cookies' or its corresponding type declarations.

1 import { Cookie } from '@netlify/node-cookies';
                         ~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in ../../node_modules/.pnpm/@netlify+serverless-functions-api@2.1.1/node_modules/@netlify/serverless-functions-api/dist/cookie_store.d.ts:1

 ELIFECYCLE  Command failed with exit code 2.

[serhalp]

It looks like @netlify/node-cookies needs to be moved from dev deps to regular deps because it's used here: https://github.com/netlify/serverless-functions-api/blob/97705a842b671e1d76a0c0bb630ab79e7394a177/src/cookie_store.ts#L1. I'm not sure how this even works currently 🤔.

🙃 hmm, already fixed this in 2023: https://github.com/netlify/serverless-functions-api/pull/140, and that was caught by a SvelteKit maintainer too! 😆

Ah ha, I see, it regressed here, but it was intentional: https://github.com/netlify/serverless-functions-api/pull/342.

cc @eduardoboucas even though we bundle dependencies, we need a prod dep here so that we emit valid .d.ts files, right?

[lachieh]

This is also the case for @netlify/edge-functions and likely any other package that includes an external reference to @netlify/types package.

Including @netlify/types in peerDependencies might work (though this depends on the package manager), but including it in dependencies would solve it for everyone. Other than that, manually specifiying the package in the tsup config under the noExternal key would work.

Not sure if it's intentional, @serhalp, but looks like the netlify/serverless-functions-api repo you mentioned is either not public or has moved.