Merge pull request #225 from netlify/chore/linting

chore: improve linting

Author: ehmicky

.eslintrc.js

@@ -3,13 +3,7 @@ const { overrides } = require('@netlify/eslint-config-node')
 module.exports = {
   extends: ['plugin:fp/recommended', '@netlify/eslint-config-node'],
   rules: {
-    // Those rules from @netlify/eslint-config-node are currently disabled
-    // TODO: remove, so those rules are enabled
-    'fp/no-mutation': 0,
-    'no-magic-numbers': 0,
-    'max-lines': 0,
-    'max-statements': 0,
-    complexity: 0,
+    'fp/no-mutation': [2, { commonjs: true }],
   },
   overrides: [...overrides],
 }

tests/line_parser.js

@@ -90,10 +90,12 @@ each(
     },
     {
       title: 'conditions_country',
+      // eslint-disable-next-line no-magic-numbers
       output: [{ path: '/', to: '/china', status: 302, conditions: { Country: 'ch,tw' } }],
     },
     {
       title: 'conditions_country_language',
+      // eslint-disable-next-line no-magic-numbers
       output: [{ path: '/', to: '/china', status: 302, conditions: { Country: 'il', Language: 'en' } }],
     },
     {
@@ -110,6 +112,7 @@ each(
         {
           path: '/donate',
           to: '/donate/usa?source=:source&email=:email',
+          // eslint-disable-next-line no-magic-numbers
           status: 302,
           query: { source: ':source', email: ':email' },
           conditions: { Country: 'us' },