This repository was archived by the owner on Jan 11, 2023. It is now read-only.
feat: add frameworks titles #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
erezrokah
commented
Feb 10, 2021
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "docusaurus-v2", | |||
| "title": "Docusaurus 2", | |||
Contributor
Author
There was a problem hiding this comment.
Explicitly use v2 in the title as referenced in https://docusaurus.io/
erezrokah
commented
Feb 10, 2021
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "quasar-v0.17", | |||
| "title": "Quasar", | |||
Contributor
Author
There was a problem hiding this comment.
Didn't include the version this time as it can mean any version lower than v1
JGAntunes
approved these changes
Feb 10, 2021
Contributor
JGAntunes
left a comment
JGAntunes
left a comment
There was a problem hiding this comment.
I take it we're already too late to change name for id without breaking a whole lot of things and requiring a whole lot of updates correct? 😅
Contributor
Author
I actually think we could do that as a breaking change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133