Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

feat: add nodeVersion option #124

Merged
merged 1 commit into from
Feb 8, 2021
Merged

feat: add nodeVersion option #124

merged 1 commit into from
Feb 8, 2021

Conversation

@erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Feb 4, 2021 •
edited
Loading

Fixes #123

This option is used here

framework-info/src/plugins.js

Line 7 in bd13880

semver.valid(minNodeVersion) && semver.valid(nodeVersion) && semver.gte(nodeVersion, minNodeVersion),

@erezrokah erezrokah requested a review from JGAntunes February 4, 2021 17:08
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 4, 2021
JGAntunes
JGAntunes approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@JGAntunes JGAntunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erezrokah erezrokah merged commit 647f94b into master Feb 8, 2021
@erezrokah erezrokah deleted the feat/allow_node_version branch February 8, 2021 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JGAntunes JGAntunes JGAntunes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: feature code contributing to the implementation of a feature and/or user facing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: allow passing nodeVersion as an option

3 participants

@erezrokah @JGAntunes