fix: update messages and fix tests

Author: erezrokah

src/utils/command.js

@@ -147,7 +147,7 @@ class BaseCommand extends Command {
         siteId: argv.siteId || (typeof argv.site === 'string' && argv.site) || state.get('siteId'),
         token,
         mode: 'cli',
-        host,
+        apiHost: host,
         pathPrefix,
         scheme,
         offline,

src/utils/init/utils.js

@@ -80,7 +80,9 @@ const getPromptInputs = async ({
       {
         type: 'confirm',
         name: 'installSinglePlugin',
-        message: `${prefix}Recommended Build Plugin: ${formatTitle(`${name} plugin`)}${EOL}➡️  Install ${name} plugin?`,
+        message: `${prefix}We're going to install this Build Plugin: ${formatTitle(
+          `${name} plugin`,
+        )}${EOL}➡️  OK to install?`,
         default: true,
       },
     ]
@@ -92,10 +94,10 @@ const getPromptInputs = async ({
     {
       type: 'checkbox',
       name: 'plugins',
-      message: `${prefix}Recommended Build Plugins: ${infos
+      message: `${prefix}We're going to install these plugins: ${infos
         .map(({ name }) => `${name} plugin`)
         .map(formatTitle)
-        .join(', ')}${EOL}➡️  Which plugins to install?`,
+        .join(', ')}${EOL}➡️  OK to install??`,
       choices: infos.map(({ name, package }) => ({ name: `${name} plugin`, value: package })),
       default: infos.map(({ package }) => package),
     },

tests/command.init.test.js

@@ -130,7 +130,7 @@ test('netlify init existing site', async (t) => {
 
     await builder.buildAsync()
     await withMockApi(routes, async ({ apiUrl, requests }) => {
-      // --force is required since we we return an existing site in the `sites` route
+      // --force is required since we return an existing site in the `sites` route
       // --manual is used to avoid the config-github flow that uses GitHub API
       const childProcess = execa(cliPath, ['init', '--force', '--manual'], {
         cwd: builder.directory,
@@ -240,7 +240,7 @@ test('netlify init new Next.js site', async (t) => {
       answer: answerWithValue('custom-functions'),
     },
     {
-      question: 'Install Next on Netlify plugin',
+      question: 'OK to install',
       answer: CONFIRM,
     },
     {
@@ -320,7 +320,7 @@ test('netlify init existing Next.js site with existing plugins', async (t) => {
       answer: answerWithValue('custom-functions'),
     },
     {
-      question: 'Install Next on Netlify plugin',
+      question: 'OK to install',
       answer: CONFIRM,
     },
     { question: 'Give this Netlify SSH public key access to your repository', answer: CONFIRM },
@@ -358,7 +358,7 @@ test('netlify init existing Next.js site with existing plugins', async (t) => {
 
     await builder.buildAsync()
     await withMockApi(routes, async ({ apiUrl, requests }) => {
-      // --force is required since we we return an existing site in the `sites` route
+      // --force is required since we return an existing site in the `sites` route
       // --manual is used to avoid the config-github flow that uses GitHub API
       const childProcess = execa(cliPath, ['init', '--force', '--manual'], {
         cwd: builder.directory,