Disable submit if on a branch

Author: arthanson

netbox_custom_objects/templates/netbox_custom_objects/custom_object_bulk_edit.html

@@ -85,7 +85,7 @@ <h2 class="col-9 offset-3">{% trans "Comments" %}</h2>
 
         <div class="btn-float-group-right">
           <a href="{{ return_url }}" class="btn btn-outline-secondary btn-float">{% trans "Cancel" %}</a>
-          <button type="submit" name="_apply" class="btn btn-primary">{% trans "Apply" %}</button>
+          <button type="submit" name="_apply" class="btn btn-primary"{% if branch_warning %} disabled{% endif %}>{% trans "Apply" %}</button>
         </div>
       </div>
     </form>

netbox_custom_objects/templates/netbox_custom_objects/custom_object_bulk_import.html

@@ -36,7 +36,7 @@
             {% if return_url %}
               <a href="{{ return_url }}" class="btn btn-outline-secondary">{% trans "Cancel" %}</a>
             {% endif %}
-            <button type="submit" name="data_submit" class="btn btn-primary">{% trans "Submit" %}</button>
+            <button type="submit" name="data_submit" class="btn btn-primary"{% if branch_warning %} disabled{% endif %}>{% trans "Submit" %}</button>
           </div>
         </div>
       </form>
@@ -68,7 +68,7 @@
             {% if return_url %}
               <a href="{{ return_url }}" class="btn btn-outline-secondary">{% trans "Cancel" %}</a>
             {% endif %}
-            <button type="submit" name="file_submit" class="btn btn-primary">{% trans "Submit" %}</button>
+            <button type="submit" name="file_submit" class="btn btn-primary"{% if branch_warning %} disabled{% endif %}>{% trans "Submit" %}</button>
           </div>
         </div>
       </form>
@@ -101,7 +101,7 @@
             {% if return_url %}
               <a href="{{ return_url }}" class="btn btn-outline-secondary">{% trans "Cancel" %}</a>
             {% endif %}
-            <button type="submit" name="file_submit" class="btn btn-primary">{% trans "Submit" %}</button>
+            <button type="submit" name="file_submit" class="btn btn-primary"{% if branch_warning %} disabled{% endif %}>{% trans "Submit" %}</button>
           </div>
         </div>
       </form>

netbox_custom_objects/templates/netbox_custom_objects/customobject_edit.html

@@ -45,4 +45,22 @@ <h3 class="col-9 offset-3 mb-3 h4">{{ group }}</h3>
       {% endif %}
     {% endfor %}
   </div>
-{% endblock form %}
+{% endblock form %}
+
+{% block buttons %}
+  <a href="{{ return_url }}" class="btn btn-outline-secondary btn-float">{% trans "Cancel" %}</a>
+  {% if object.pk %}
+    <button type="submit" name="_update" class="btn btn-primary"{% if branch_warning %} disabled{% endif %}>
+      {% trans "Save" %}
+    </button>
+  {% else %}
+    <div class="btn-group" role="group" aria-label="{% trans "Actions" %}">
+      <button type="submit" name="_create" class="btn btn-primary"{% if branch_warning %} disabled{% endif %}>
+        {% trans "Create" %}
+      </button>
+      <button type="submit" name="_addanother" class="btn btn-outline-primary btn-float"{% if branch_warning %} disabled{% endif %}>
+        {% trans "Create & Add Another" %}
+      </button>
+    </div>
+  {% endif %}
+{% endblock buttons %}

netbox_custom_objects/templates/netbox_custom_objects/inc/branch_warning.html

@@ -6,7 +6,7 @@
   </span>
   <span class="flex-fill">
   {% blocktrans trimmed  %}
-    This object has fields that reference objects in other apps and you have a branch active. Care must be taken to not reference an object that only exists in another branch.
+    Please switch to the main branch to perform this operation.
   {% endblocktrans %}
   </span>
 </div>

netbox_custom_objects/views.py

@@ -574,20 +574,8 @@ def custom_save(self, commit=True):
         return form_class
 
     def get_extra_context(self, request, obj):
-
-        # Check if we're in a branch and if there are external object pointers
-        has_external_object_pointers = False
-        if is_in_branch():
-            # Check all fields in the custom object type
-            for field in self.object.custom_object_type.fields.all():
-                if field.type in [CustomFieldTypeChoices.TYPE_OBJECT, CustomFieldTypeChoices.TYPE_MULTIOBJECT]:
-                    # Check if the related object type is not from the current app
-                    if field.related_object_type.app_label != APP_LABEL:
-                        has_external_object_pointers = True
-                        break
-
         return {
-            'branch_warning': has_external_object_pointers,
+            'branch_warning': is_in_branch(),
         }
 
 
@@ -692,20 +680,8 @@ def get_form(self, queryset):
         return form
 
     def get_extra_context(self, request):
-
-        # Check if we're in a branch and if there are external object pointers
-        has_external_object_pointers = False
-        if is_in_branch():
-            # Check all fields in the custom object type
-            for field in self.custom_object_type.fields.all():
-                if field.type in [CustomFieldTypeChoices.TYPE_OBJECT, CustomFieldTypeChoices.TYPE_MULTIOBJECT]:
-                    # Check if the related object type is not from the current app
-                    if field.related_object_type.app_label != APP_LABEL:
-                        has_external_object_pointers = True
-                        break
-
         return {
-            'branch_warning': has_external_object_pointers,
+            'branch_warning': is_in_branch(),
         }
 
 
@@ -795,20 +771,8 @@ def get_model_form(self, queryset):
         return form
 
     def get_extra_context(self, request):
-
-        # Check if we're in a branch and if there are external object pointers
-        has_external_object_pointers = False
-        if is_in_branch():
-            # Check all fields in the custom object type
-            for field in self.custom_object_type.fields.all():
-                if field.type in [CustomFieldTypeChoices.TYPE_OBJECT, CustomFieldTypeChoices.TYPE_MULTIOBJECT]:
-                    # Check if the related object type is not from the current app
-                    if field.related_object_type.app_label != APP_LABEL:
-                        has_external_object_pointers = True
-                        break
-
         return {
-            'branch_warning': has_external_object_pointers,
+            'branch_warning': is_in_branch(),
         }