-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Remote groups via HTTP Headers #6730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your interest in contributing to NetBox, however it appears there is no accepted issue that correlates to this pull request. Before pull requests are opened, we require an accepted issue as per our contributing guide. Please first open an issue and wait for it to be accepted before further work is done on this pull request. |
|
@jeremystretch there is :D |
|
Ok, I see that. For future, please be sure to retain the |
|
Can we get some remote authentication users to test this and weigh in here? |
|
Successfully tested with oauth2-proxy and keycloak |
2ffc0cb to
9fe454e
Compare
fix incorrect assumption about when to run the group sync Add documentation for new Settings format to autopep8 compliance add first set of basic testcases format test to comply with pep8 rename SEPERATOR to SEPARATOR remove accidentally carried over parameter
9fe454e to
d5e5cdd
Compare
|
Just noticed this will test with http header auth |
|
I've patched the 3.0.2 release tag with this diff on our dev box and SSO login continues to work. I say continues as we patched the previous version (2.11) as well, not sure if that previous patch was the same as this one or different as the person who did it said it was 'based on it'. upstream auth is Okta |
|
@davama were you able to test this? Can you share your findings? |
|
@jeremystretch @mackaybe works good 👍 Would be awesome if |
Fixes: #5775
Unlike the LDAP Backend, the RemoteUserBackend wasnt able to Sync Group memberships form the auth Provider.
This brings it up to parity, as the new Settings give you the Option to setup an automatic Group Sync (and revocation) on each User login.
This has been tested with oauth2-proxy
The old behaviopur of just Syncing Users and then manually managing Groups should be unaffected.
ToDo: