Skip to content

Conversation

@arthanson
Copy link
Collaborator

@arthanson arthanson commented Apr 23, 2025

Fixes: #16238

Adds CSS styling for missing btn-white, btn-black, btn-grey. Note CSS extend doesn't catch all potential styling on elements depending on how the selectors are defined (see https://stackoverflow.com/questions/13335544/how-to-alias-class-name-in-css-or-sass) but it appears all the styling is good for these buttons.

Note: ghost-dark (used for LINK type) is a tabler button but in the version of tabler we use link text doesn't display in dark mode, should be fixed in latest version of tabler.

@arthanson arthanson marked this pull request as ready for review April 23, 2025 17:46
@arthanson arthanson requested review from a team and jeremystretch and removed request for a team April 23, 2025 17:46
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than re-mapping the color values, could we just add CSS aliases to provide backward compatibility? IMO this is a less confusing approach.

.btn-white {
  @extend .btn-light;
}

.btn-black {
  @extend .btn-dark;
}

@arthanson arthanson requested a review from jeremystretch April 23, 2025 21:09
@jeremystretch jeremystretch merged commit d0c2e0e into main Apr 24, 2025
10 checks passed
@jeremystretch jeremystretch deleted the 16238-button-color branch April 24, 2025 12:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom link button colour(s) affected by dark mode

3 participants