Fixes #18991: AttributeError: NoneType object has not attribute model #19006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GenericArrayForeignKey`, which was added in #18826, advertised itself as a many_to_many relation, which is somewhat inaccurate and triggered DRF's introspection of many_to_many relations which looks for a `remote_field.model` property chain on the relation. Since that doesn't exist, DRF threw an AttributeError resulting in a 500 error. This changes `GenericArrayForeignKey` to advertise itself to DRF as a one_to_many relation, which is more accurate, and does not trigger the property access in DRF that was causing the problem. This also adds a regression test for both FrontPort and RearPort "path" API view.
jnovinger
requested review from
a team and
arthanson
and removed request for
a team
arthanson
approved these changes
Mar 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18991
GenericArrayForeignKey, which was added in #18826, advertised itself as a many_to_many relation, which is seemingly somewhat inaccurate and triggered DRF's introspection of many_to_many relations which looks for aremote_field.modelproperty chain on the relation. Since that doesn't exist, DRF threw an AttributeError resulting in a 500 error.This changes
GenericArrayForeignKeyto advertise itself to DRF as a one_to_many relation, which is more accurate, and does not trigger the property access in DRF that was causing the problem.This also adds a regression test for both FrontPort and RearPort "path" API views.