Skip to content

Conversation

@atownson
Copy link
Contributor

Closes: #18024

Added script URL patterns to include the module and name references. Added a function to return the specified script when referenced by either the PK or the module.name pattern. The new URL patterns should match the existing URL patterns for the API.

@jeremystretch jeremystretch requested review from a team and jnovinger and removed request for a team February 24, 2025 16:45
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick action @atownson ! I just have a couple of change requests.

The note about the walrus operator is just a suggestion.

Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atownson

@jeremystretch jeremystretch merged commit 48b825c into netbox-community:main Feb 25, 2025
3 checks passed
bctiemann pushed a commit that referenced this pull request Mar 6, 2025
…e.name (#18723)

* Add URL pattern for scripts to reference them by module.name

* Change _get_script function name and syntax

* Fix formatting issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2025
@atownson atownson deleted the issue_18024 branch March 31, 2025 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add UI URL pattern for scripts to allow a specific script to be accessed by module and class in addition to ID

3 participants