Skip to content

Fixes #17332: Restore pagination for object list dashboard widgets #17370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fixes #17332: Restore pagination for object list dashboard widgets #17370

merged 1 commit into from
Sep 4, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Sep 4, 2024

Fixes: #17332

  • Set hx-disinherit="*" on the parent dashboard element to negate the hx-select attribute of the parent page element when HTMX navigation is enabled.
  • Remove the now-obsolete hx-select attribute from the widget's HTMX container element.

@jeremystretch jeremystretch mentioned this pull request Sep 4, 2024
Closed
@jeremystretch jeremystretch merged commit 5c33aa8 into develop Sep 4, 2024
@jeremystretch jeremystretch deleted the 17332-dashboard-widget-pagination branch September 4, 2024 20:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pagination on Widgets in Dashboard

3 participants

@jeremystretch @arthanson