17117 change caret to html entity to fix safari performacne issue #17246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
arthanson
changed the title
jeremystretch
requested changes
Aug 26, 2024
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
The icon isn't aligned vertically with the menu item text:
jeremystretch
approved these changes
Aug 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17117
Tabler was creating the caret for the sidebar and buttons via a border and then doing a transform rotation of 45-degrees. This was causing a performance issue on safari. Changed the css to get rid of the transform and use the material icon for the caret.
In screenshot left is old, right is new: