Skip to content

Closes #16290: Capture entire object in changelog data #16325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

Closes #16290: Capture entire object in changelog data #16325

merged 1 commit into from
May 29, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented May 28, 2024

Fixes: #16290

  • Modify serialize_object() utility function so that it no longer excludes private/MPTT fields
  • Add "clean" attributes for pre- & post-change data on ObjectChange
  • Update the API serializers and UI views to display only the "clean" (non-private) change data
  • Extend changelog test to check for the presence of non-private data
  • Miscellaneous cosmetic tweaks

@jeremystretch jeremystretch requested a review from arthanson May 28, 2024 18:13
@jeremystretch jeremystretch merged commit a094719 into develop May 29, 2024
@jeremystretch jeremystretch deleted the 16290-improve-object-serialization branch May 29, 2024 13:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include "private" fields when serializing objects for change logging

3 participants

@jeremystretch @arthanson