Skip to content

#15999 Login form #16006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

#15999 Login form #16006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion netbox/templates/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,21 @@ <h2 class="text-center mb-4">{% trans "Log In" %}</h2>
<input type="hidden" name="next" value="{{ request.POST.next }}" />
{% endif %}

{% render_form form %}
<div class="form-group">
<label for="id_username" style="font-weight: bold; margin-bottom: 5px;">{{ form.username.label }}</label>
Copy link
Member

@jeremystretch jeremystretch May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid using inline CSS wherever possible. Bootstrap provides plenty of convenient utility classes for this purpose.

Copy link
Member

@jeremystretch jeremystretch May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to keep a two-space indentation for each child element.

{{ form.username }}
{% for error in form.username.errors %}
<div class="alert alert-danger">{{ error }}</div>
{% endfor %}
</div>

<div class="form-group">
Copy link
Member

@jeremystretch jeremystretch May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't enough space between the two form fields. Try adding the mb-3 class or similar to the first group.

screenshot

<label for="id_password" style="font-weight: bold; margin-bottom: 5px;">{{ form.password.label }}</label>
{{ form.password }}
{% for error in form.password.errors %}
<div class="alert alert-danger">{{ error }}</div>
{% endfor %}
</div>

<div class="form-footer">
<button type="submit" class="btn btn-primary w-100">
Expand Down