Fixes #14945: Fix "select all" button for device type components #15027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
requested changes
Feb 5, 2024
Collaborator
arthanson
left a comment
arthanson
left a comment
There was a problem hiding this comment.
I'm not sure if the buttons are correct here - the edit and rename buttons aren't separated and the rename is light-yellow text on white background which isn't great for readability (light background).
Member
Author
|
Yep, this is correct; it's the same way action buttons for device components appear. (The styling is being updated as part of the UI refresh in v4.0 anyway. The goal here is just to achieve consistency with similar views.) |
jeremystretch
force-pushed
the
14945-fix-select-all
branch
from
09ea656 to
45956e3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14945
This updates the
component_templates.htmltemplate to inherit from the standard template for subclasses ofgeneric.ObjectChildrenView.