From 9fd40ea86fe4958643c07b594be3983027e3fd6c Mon Sep 17 00:00:00 2001 From: Arthur Date: Tue, 5 Dec 2023 11:14:02 -0800 Subject: [PATCH 1/2] 14401 validate rack startion position > 0 --- .../0182_alter_rack_starting_unit.py | 18 ++++++++++++++++++ netbox/dcim/models/racks.py | 1 + 2 files changed, 19 insertions(+) create mode 100644 netbox/dcim/migrations/0182_alter_rack_starting_unit.py diff --git a/netbox/dcim/migrations/0182_alter_rack_starting_unit.py b/netbox/dcim/migrations/0182_alter_rack_starting_unit.py new file mode 100644 index 00000000000..5b0fc6ce48a --- /dev/null +++ b/netbox/dcim/migrations/0182_alter_rack_starting_unit.py @@ -0,0 +1,18 @@ +# Generated by Django 4.2.5 on 2023-12-05 19:13 + +import django.core.validators +from django.db import migrations, models + + +class Migration(migrations.Migration): + dependencies = [ + ('dcim', '0181_rename_device_role_device_role'), + ] + + operations = [ + migrations.AlterField( + model_name='rack', + name='starting_unit', + field=models.PositiveSmallIntegerField(default=1, validators=[django.core.validators.MinValueValidator(1)]), + ), + ] diff --git a/netbox/dcim/models/racks.py b/netbox/dcim/models/racks.py index ef0dde4dac9..a0614abcb0d 100644 --- a/netbox/dcim/models/racks.py +++ b/netbox/dcim/models/racks.py @@ -141,6 +141,7 @@ class Rack(ContactsMixin, ImageAttachmentsMixin, PrimaryModel, WeightMixin): starting_unit = models.PositiveSmallIntegerField( default=RACK_STARTING_UNIT_DEFAULT, verbose_name=_('starting unit'), + validators=[MinValueValidator(1),], help_text=_('Starting unit for rack') ) desc_units = models.BooleanField( From 8808a1ec496b0ce1daa73992e16e50851d1a3ecc Mon Sep 17 00:00:00 2001 From: Arthur Date: Tue, 5 Dec 2023 13:37:33 -0800 Subject: [PATCH 2/2] 14401 review changes - remove migration --- .../dcim/migrations/0174_rack_starting_unit.py | 3 ++- .../0182_alter_rack_starting_unit.py | 18 ------------------ 2 files changed, 2 insertions(+), 19 deletions(-) delete mode 100644 netbox/dcim/migrations/0182_alter_rack_starting_unit.py diff --git a/netbox/dcim/migrations/0174_rack_starting_unit.py b/netbox/dcim/migrations/0174_rack_starting_unit.py index e32738660a3..2d2b5f82646 100644 --- a/netbox/dcim/migrations/0174_rack_starting_unit.py +++ b/netbox/dcim/migrations/0174_rack_starting_unit.py @@ -1,5 +1,6 @@ # Generated by Django 4.1.9 on 2023-05-31 15:47 +import django.core.validators from django.db import migrations, models @@ -12,6 +13,6 @@ class Migration(migrations.Migration): migrations.AddField( model_name='rack', name='starting_unit', - field=models.PositiveSmallIntegerField(default=1), + field=models.PositiveSmallIntegerField(default=1, validators=[django.core.validators.MinValueValidator(1)]), ), ] diff --git a/netbox/dcim/migrations/0182_alter_rack_starting_unit.py b/netbox/dcim/migrations/0182_alter_rack_starting_unit.py deleted file mode 100644 index 5b0fc6ce48a..00000000000 --- a/netbox/dcim/migrations/0182_alter_rack_starting_unit.py +++ /dev/null @@ -1,18 +0,0 @@ -# Generated by Django 4.2.5 on 2023-12-05 19:13 - -import django.core.validators -from django.db import migrations, models - - -class Migration(migrations.Migration): - dependencies = [ - ('dcim', '0181_rename_device_role_device_role'), - ] - - operations = [ - migrations.AlterField( - model_name='rack', - name='starting_unit', - field=models.PositiveSmallIntegerField(default=1, validators=[django.core.validators.MinValueValidator(1)]), - ), - ]