13757 Fix ConfigContext reference to DeviceType #13804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi1693
reviewed
Sep 18, 2023
Member
abhi1693
left a comment
abhi1693
left a comment
There was a problem hiding this comment.
I'm not sure if it's really possible, but a test case to ensure this doesn't creep in later
arthanson
changed the title
arthanson
changed the title
Member
|
Thanks @arthanson! |
jeremystretch
approved these changes
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13757
As per Django issue https://code.djangoproject.com/ticket/34847 problem arises as DeviceType has variable references in init method. Recommendation is to access vars in init with self.__dict as they state this will probably be documented this way as there is no good fix for dereferenced vars except for this.
Changed ConfigContext test case save devicetype to catch if this ever regresses.