Skip to content

Closes #13638: Add optional staff_only attribute to MenuItem #13639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 31, 2023
Merged

Closes #13638: Add optional staff_only attribute to MenuItem #13639

merged 3 commits into from
Aug 31, 2023

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Aug 31, 2023

Fixes: #13638

  • Add optional staff_only boolean attribute to MenuItem dataclass
  • Modify menu rendering logic to evaluate staff_only against user's is_staff status

@jeremystretch jeremystretch merged commit f962fb3 into develop Aug 31, 2023
@jeremystretch jeremystretch deleted the 13638-menuitem-staff-only branch August 31, 2023 15:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable controlling the display of navigation menu items depending on the user's is_staff status

3 participants

@jeremystretch @arthanson