From 0f1247c6ef06847940a4e5fcbabfc05248e34867 Mon Sep 17 00:00:00 2001 From: Jamie Murphy Date: Wed, 30 Aug 2023 22:05:45 +0100 Subject: [PATCH 1/2] fix error for is_oob_ip for non-device parents --- netbox/ipam/models/ip.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netbox/ipam/models/ip.py b/netbox/ipam/models/ip.py index 553f5eb9212..a0531c02821 100644 --- a/netbox/ipam/models/ip.py +++ b/netbox/ipam/models/ip.py @@ -892,7 +892,7 @@ def family(self): def is_oob_ip(self): if self.assigned_object: parent = getattr(self.assigned_object, 'parent_object', None) - if parent.oob_ip_id == self.pk: + if parent.__class__.__name__ == "Device" and parent.oob_ip_id == self.pk: return True return False From bb8348d6390668ea21d08bd2adb28bd3ebb42ca1 Mon Sep 17 00:00:00 2001 From: Jamie Murphy Date: Wed, 30 Aug 2023 22:19:35 +0100 Subject: [PATCH 2/2] adjust oob_ip_id check to use hasattr --- netbox/ipam/models/ip.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netbox/ipam/models/ip.py b/netbox/ipam/models/ip.py index a0531c02821..af0a0ef451c 100644 --- a/netbox/ipam/models/ip.py +++ b/netbox/ipam/models/ip.py @@ -892,7 +892,7 @@ def family(self): def is_oob_ip(self): if self.assigned_object: parent = getattr(self.assigned_object, 'parent_object', None) - if parent.__class__.__name__ == "Device" and parent.oob_ip_id == self.pk: + if hasattr(parent, "oob_ip_id") and parent.oob_ip_id == self.pk: return True return False