Adds rename button on the list page for device components #13564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSheps
requested changes
Aug 30, 2023
Member
DanSheps
left a comment
DanSheps
left a comment
There was a problem hiding this comment.
I am not sure if you saw the comment from Jeremy but this should be extended to all component views.
Member
Author
|
@DanSheps Thanks, I really did miss that comment. |
abhi1693
changed the title
DanSheps
approved these changes
Aug 30, 2023
Member
DanSheps
left a comment
DanSheps
left a comment
There was a problem hiding this comment.
I see a lot of code duplication. Any thoughts on a way to perhaps deduplicate some of this?
For example, a Mixin for ListView like "DeviceComponentListViewMixin", and then have a single template ("devicecomponent_list.html"). Just a thought, not saying we should or have to do this.
Otherwise, it looks good.
Member
|
I've converged the model-specific templates into a single one following the pattern we have for component lists under the device view. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13444