From d171307e0f71d774b1231642c0dfc577f929779c Mon Sep 17 00:00:00 2001 From: Abhimanyu Saharan Date: Thu, 24 Aug 2023 18:39:19 +0530 Subject: [PATCH 1/2] fixed permission for config context UI view #13543 --- netbox/extras/views.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/netbox/extras/views.py b/netbox/extras/views.py index 6ba63ab584b..aa5669d06fb 100644 --- a/netbox/extras/views.py +++ b/netbox/extras/views.py @@ -17,6 +17,7 @@ from netbox.views import generic from utilities.forms import ConfirmationForm, get_field_value from utilities.htmx import is_htmx +from utilities.permissions import get_permission_for_model from utilities.rqworker import get_workers_for_queue from utilities.templatetags.builtins.filters import render_markdown from utilities.utils import copy_safe_request, count_related, get_viewname, normalize_querydict, shallow_compare_dict @@ -434,6 +435,9 @@ class ObjectConfigContextView(generic.ObjectView): base_template = None template_name = 'extras/object_configcontext.html' + def get_required_permission(self): + return get_permission_for_model(ConfigContext, 'view') + def get_extra_context(self, request, instance): source_contexts = ConfigContext.objects.restrict(request.user, 'view').get_for_object(instance) From f152cd114cf125c494caecba5089eaed43031ae8 Mon Sep 17 00:00:00 2001 From: Abhimanyu Saharan Date: Thu, 24 Aug 2023 21:35:46 +0530 Subject: [PATCH 2/2] removed extras.view_configcontext permission #13543 --- netbox/dcim/views.py | 1 - netbox/extras/views.py | 4 ---- netbox/virtualization/views.py | 1 - 3 files changed, 6 deletions(-) diff --git a/netbox/dcim/views.py b/netbox/dcim/views.py index fca222f47ad..2f5da4ce143 100644 --- a/netbox/dcim/views.py +++ b/netbox/dcim/views.py @@ -2055,7 +2055,6 @@ class DeviceConfigContextView(ObjectConfigContextView): base_template = 'dcim/device/base.html' tab = ViewTab( label=_('Config Context'), - permission='extras.view_configcontext', weight=2000 ) diff --git a/netbox/extras/views.py b/netbox/extras/views.py index aa5669d06fb..6ba63ab584b 100644 --- a/netbox/extras/views.py +++ b/netbox/extras/views.py @@ -17,7 +17,6 @@ from netbox.views import generic from utilities.forms import ConfirmationForm, get_field_value from utilities.htmx import is_htmx -from utilities.permissions import get_permission_for_model from utilities.rqworker import get_workers_for_queue from utilities.templatetags.builtins.filters import render_markdown from utilities.utils import copy_safe_request, count_related, get_viewname, normalize_querydict, shallow_compare_dict @@ -435,9 +434,6 @@ class ObjectConfigContextView(generic.ObjectView): base_template = None template_name = 'extras/object_configcontext.html' - def get_required_permission(self): - return get_permission_for_model(ConfigContext, 'view') - def get_extra_context(self, request, instance): source_contexts = ConfigContext.objects.restrict(request.user, 'view').get_for_object(instance) diff --git a/netbox/virtualization/views.py b/netbox/virtualization/views.py index 92a91f47e81..9c09d697b3c 100644 --- a/netbox/virtualization/views.py +++ b/netbox/virtualization/views.py @@ -384,7 +384,6 @@ class VirtualMachineConfigContextView(ObjectConfigContextView): base_template = 'virtualization/virtualmachine.html' tab = ViewTab( label=_('Config Context'), - permission='extras.view_configcontext', weight=2000 )