Fixes #12639 - Make sure name expansions throws a validation error on decrementing ranges #13326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12639
The code is a tiny bit messy, but I did my best.
Changes:
parse_alphanumeric_rangenow throws aValidationErrorwhen its passed decrementing ranges.ComponentCreateFormclean method has been slightly reworked to bail out if the name field is not in cleaned_data. Not quite sure what is going on, but I think it's because validation continues even if the above ValidationError is thrown.Tests passes now, but please give it a test to make sure I didn't mess anything up. The logic for expandable fields is a little hard to grok.