Adds stroke to the reservation #12506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It looks like the righthand side of the reservation bar border is getting clipped. Stroke can be tricky to deal with: you may need to adjust the height/width of elements to accommodate the "extra" pixels added by the stroke width. |
Member
Author
|
|
Member
|
I tweaked the stroke style and position a bit further to ensure that we're rendering the full 2px width on both sides, changed the stroke color to match the gradient, and added a bit of space between the rack border and the reservation block.
|
jsenecal
pushed a commit
to jsenecal/netbox
that referenced
this pull request
May 18, 2023
* adds stroke to the reservation netbox-community#11900 * fixed right side border * Tweak reserved stroke style & add constants for colors --------- Co-authored-by: jeremystretch <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11900
Preview of how it looks
