Skip to content

Conversation

@arthanson
Copy link
Collaborator

Fixes: #11014

Fixes rack elevation sorting order for name, use _name instead of name to sort by.

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to avoid exposing the _name field (with the leading underscore) to the user. It might be cleaner to keep name and -name in place, but swap them for _name and -_name respectively when calling order_by().

@arthanson
Copy link
Collaborator Author

We probably want to avoid exposing the _name field (with the leading underscore) to the user. It might be cleaner to keep name and -name in place, but swap them for _name and -_name respectively when calling order_by().

Done

@jeremystretch jeremystretch merged commit 00d72f1 into develop Nov 30, 2022
@jeremystretch jeremystretch deleted the 11014-rack-elevation-sort branch November 30, 2022 20:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elevations View Rack Name Number Sort

3 participants