Site selection in Prefix creation dialog does not limit VLAN group selection

[stephanblanke]

NetBox version

v3.1.10-dev

Python version

3.9

Steps to Reproduce

1. Open the prefix creation form
2. Under "Site/VLAN Assignment" select a site from the list
3. Open selection menu for VLAN Group

Expected Behavior

Selecting a site from the list should limit the available VLAN Groups, that can be selected from the list.

Observed Behavior

Selecting a site from the list has no impact on the list of available VLAN Groups.

[stephanblanke]

I think the bug is here:

netbox/netbox/ipam/forms/models.py

Lines 219 to 230 in f64987d

	vlan_group = DynamicModelChoiceField(
	queryset=VLANGroup.objects.all(),
	required=False,
	label='VLAN group',
	null_option='None',
	query_params={
	'site_id': '$site'
	},
	initial_params={
	'vlans': '$vlan'
	}
	)

Changing site_id to scope_id (line 225) and ading scope_type = 'dcim.site' (before line 226) would work, but in that case VLAN groups that are not assigned to a specific site would not be displayed anymore. I am unsure, if that would be the desired behaviour.

[jeremystretch]

Close; site_id should be site. Thanks for the report!