Help Link for FHRP Group Assignment not working (404 Not Found)

[991jo]

NetBox version

v3.1.8

Python version

3.9

Steps to Reproduce

1. create a device
2. add an interface
3. go to the interface view
4. press the "Assign Group" Button on the FHRP Group card
5. Press the "Help" Button on the top-right of the page

Expected Behavior

A either a help page is shown explaining FHRP group assignments or no help button is shown at all.

Observed Behavior

The web server returns a 404 Not Found.
Other help pages work as intended.
The path a user is send to is /static/docs/models/ipam/fhrpgroupassignment/index.html

[ritkit]

I can take a stab at this as a first contribution.

[JonathonReinhart]

It looks like "FHRP Group Assignments" is just a section on the fhrpgroup page. So the correct URL should be: /static/docs/models/ipam/fhrpgroup/#fhrp-group-assignments

[ritkit]

It looks like "FHRP Group Assignments" is just a section on the fhrpgroup page. So the correct URL should be: /static/docs/models/ipam/fhrpgroup/#fhrp-group-assignments

You are absolutely correct. However, it looks like the url for help is built based on the actual Forms URL/model information.
Currently the function that creates this URL is below

helpers.py

@register.filter()
def get_docs_url(model):
    """
    Return the documentation URL for the specified model.
    """
    return f'{settings.STATIC_URL}docs/models/{model._meta.app_label}/{model._meta.model_name}/'

However in the code above when the model name is passed it is FHRPGroupAssignment and therefor used in the URL.

So I see two choices.

1. Create a wholly different page in Docs for FHRP Group Assignments. Though this seems like overkill for its own page.
2. Add some crazy one off catch all for pages like this, but now it less dynamic. I hate this idea but it is an option.
3. Add to the model to be able to define children so they can be called with /ParentModel/#Childname.

The third choice seems daunting to me but could be quite helpful in the long run. @jeremystretch any ideas?

[jeremystretch]

This just needs a separate page in the docs. I'll take care of it.