-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
status: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: bugA confirmed report of unexpected behavior in the applicationA confirmed report of unexpected behavior in the application
Description
NetBox version
v3.4.1
Python version
3.8
Steps to Reproduce
- put a breakpoint or print statement on a_terminations setter (https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/models/cables.py#L121)
- Edit a cable and save it (making no modifications)
- See that the breakpoint is hit and therefore _terminations_modified is set.
This is a problem as the signal handler (https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/signals.py#L84) will check _terminations_modified and create a new cablepath.
Expected Behavior
_terminations_modified should only get set if the terminations are actually changed.
Observed Behavior
_terminations_modified is set even if terminations are not changed.
Metadata
Metadata
Assignees
Labels
status: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: bugA confirmed report of unexpected behavior in the applicationA confirmed report of unexpected behavior in the application