fixed #16853: accessibility issues

Andrew Gormley · jeremystretch · commit 561f50561fd7 · 2024-07-11T13:01:13.000-04:00
diff --git a/netbox/netbox/tables/columns.py b/netbox/netbox/tables/columns.py
@@ -275,7 +275,7 @@ def render(self, record, table, **kwargs):
                 if len(self.actions) == 1 or (self.split_actions and idx == 0):
                     dropdown_class = attrs.css_class
                     button = (
-                        f'<a class="btn btn-sm btn-{attrs.css_class}" href="{url}{url_appendix}" type="button">'
+                        f'<a class="btn btn-sm btn-{attrs.css_class}" href="{url}{url_appendix}" type="button" aria-label="{attrs.title}">'
                         f'<i class="mdi mdi-{attrs.icon}"></i></a>'
                     )
 
diff --git a/netbox/templates/base/base.html b/netbox/templates/base/base.html
@@ -11,7 +11,7 @@
   >
   <head>
     <meta charset="UTF-8" />
-    <meta name="viewport" content="initial-scale=1, maximum-scale=1, user-scalable=no, width=device-width, viewport-fit=cover" />
+    <meta name="viewport" content="initial-scale=1, maximum-scale=5, width=device-width, viewport-fit=cover" />
     <meta name="htmx-config" content='{"scrollBehavior": "auto"}'>
 
     {# Page title #}
diff --git a/netbox/templates/dcim/rack_elevation_list.html b/netbox/templates/dcim/rack_elevation_list.html
@@ -11,7 +11,7 @@
       <a href="{% url 'dcim:rack_list' %}{% querystring request %}" class="btn btn-primary">
         <i class="mdi mdi-format-list-checkbox"></i> {% trans "View List" %}
       </a>
-      <select class="btn btn-outline-secondary no-ts rack-view">
+      <select class="btn btn-outline-secondary no-ts rack-view" aria-label="Select rack view">
         <option value="images-and-labels" selected="selected">{% trans "Images and Labels" %}</option>
         <option value="images-only">{% trans "Images only" %}</option>
         <option value="labels-only">{% trans "Labels only" %}</option>

Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ def render(self, record, table, **kwargs):`
`275`	`275`	`if len(self.actions) == 1 or (self.split_actions and idx == 0):`
`276`	`276`	`dropdown_class = attrs.css_class`
`277`	`277`	`button = (`
`278`		`- f'<a class="btn btn-sm btn-{attrs.css_class}" href="{url}{url_appendix}" type="button">'`
	`278`	`+ f'<a class="btn btn-sm btn-{attrs.css_class}" href="{url}{url_appendix}" type="button" aria-label="{attrs.title}">'`
`279`	`279`	`f'<i class="mdi mdi-{attrs.icon}"></i></a>'`
`280`	`280`	`)`
`281`	`281`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`>`
`12`	`12`	`<head>`
`13`	`13`	`<meta charset="UTF-8" />`
`14`		`- <meta name="viewport" content="initial-scale=1, maximum-scale=1, user-scalable=no, width=device-width, viewport-fit=cover" />`
	`14`	`+ <meta name="viewport" content="initial-scale=1, maximum-scale=5, width=device-width, viewport-fit=cover" />`
`15`	`15`	`<meta name="htmx-config" content='{"scrollBehavior": "auto"}'>`
`16`	`16`
`17`	`17`	`{# Page title #}`