#10170 changes from code review

Author: arthanson

netbox/extras/tables/tables.py

@@ -183,6 +183,7 @@ class ObjectChangeTable(NetBoxTable):
         verbose_name='Username'
     )
     full_name = tables.TemplateColumn(
+        accessor=tables.A('user'),
         template_code=OBJECTCHANGE_FULL_NAME,
         verbose_name='Full Name',
         orderable=False
@@ -192,6 +193,7 @@ class ObjectChangeTable(NetBoxTable):
         verbose_name='Type'
     )
     object_repr = tables.TemplateColumn(
+        accessor=tables.A('object_repr'),
         template_code=OBJECTCHANGE_OBJECT,
         verbose_name='Object'
     )

netbox/extras/tables/template_code.py

@@ -13,8 +13,8 @@
 """
 
 OBJECTCHANGE_OBJECT = """
-{% if record.changed_object and record.changed_object.get_absolute_url %}
-    <a href="{{ record.changed_object.get_absolute_url }}">{{ record.object_repr }}</a>
+{% if value.changed_object and value.changed_object.get_absolute_url %}
+    <a href="{{ value.changed_object.get_absolute_url }}">{{ record.object_repr }}</a>
 {% else %}
     {{ record.object_repr }}
 {% endif %}

netbox/extras/views.py

@@ -361,7 +361,7 @@ def get_extra_context(self, request, instance):
 #
 
 class ObjectChangeListView(generic.ObjectListView):
-    queryset = ObjectChange.objects.all().select_related("user").prefetch_related("changed_object")
+    queryset = ObjectChange.objects.all()
     filterset = filtersets.ObjectChangeFilterSet
     filterset_form = forms.ObjectChangeFilterForm
     table = tables.ObjectChangeTable