Enhancement: Allow id for api_filter that uses .get instead of .filter #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkdd
added a commit
to linkdd/ansible_modules
that referenced
this pull request
Jul 28, 2023
In the `nb_lookup` plugin, if we provide an `api_filter` containing the `id` field, it will use `.get()` instead of `.filter()`, thus returning the item instead of a list. See PR netbox-community#376 for more information. This is fine if you supply only one id. But let's say you want to get a list of items by ids? For example: `id=1 id=5` I would expect to get a list of 2 items. But at the moment, it will return the first item only. This change adds a simple check to see if we're supplying multiple ids.
3 tasks
rodvand
pushed a commit
that referenced
this pull request
Dec 10, 2023
In the `nb_lookup` plugin, if we provide an `api_filter` containing the `id` field, it will use `.get()` instead of `.filter()`, thus returning the item instead of a list. See PR #376 for more information. This is fine if you supply only one id. But let's say you want to get a list of items by ids? For example: `id=1 id=5` I would expect to get a list of 2 items. But at the moment, it will return the first item only. This change adds a simple check to see if we're supplying multiple ids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370