Update meta/runtime.yml With Missing Modules #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears some modules cannot take advantage of module_defaults, it appears to be due to them missing in the netbox action group.
k-304
pushed a commit
to cloudscale-ch/netbox-community.ansible_modules
that referenced
this pull request
Apr 7, 2025
* Add modules to runtime.yml It appears some modules cannot take advantage of module_defaults, it appears to be due to them missing in the netbox action group. * changelog-fragment * add file extension to change fragement
k-304
pushed a commit
to cloudscale-ch/netbox-community.ansible_modules
that referenced
this pull request
Apr 7, 2025
* Add modules to runtime.yml It appears some modules cannot take advantage of module_defaults, it appears to be due to them missing in the netbox action group. * changelog-fragment * add file extension to change fragement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules like
netbox_user_groupcannot take advantage of module_defaults for arguments likenetbox_urlandnetbox_token.This appear to be due to the netbox action group not containing those modules. This PR is to add missing modules to the netbox action group.
Related Issue
Initial implementation of action group to support module_defaults.
#411
New Behavior
Modules defaults work with all current netbox ansible modules.
Contrast to Current Behavior
Module defaults like
netbox_urlandnetbox_tokendo not get inherited by modules not listed in the netbox action_group. With the modules likenetbox_user_groupadded, they now inherit the module_defaults.Discussion: Benefits and Drawbacks
Consistent module_default parameter inheritance across all modules.
Proposed Release Note Entry
Added modules
netbox_config_template,netbox_custom_field_choice_set,netbox_permission,netbox_token,netbox_user, andnetbox_user_groupto the netbox action group to support module_default parameter inheritance in those modules.Double Check
develbranch.