Bump minimum Python version to 3.10 (#1153)

* Bump minimum Python version to 3.10

* Clean-up: lift code base to Python 3.10

* Error hard on some protocol violations

When the announced record fields don't match the number of fields returned
in the following `RECORD` messages, the driver should properly error and not
silently swallow some fields.

* Remove outdated linter&formatter exceptions

Author: robsdedude

CHANGELOG.md

@@ -3,7 +3,7 @@
 See also https://github.com/neo4j/neo4j-python-driver/wiki for a full changelog.
 
 ## NEXT RELEASE
-- No breaking or major changes.
+- Python 3.7, 3.8, and 3.9 support has been dropped.
 
 
 ## Version 5.28

CONTRIBUTING.md

@@ -58,7 +58,7 @@ install the pre-commit hooks as described below instead. They will take care of
 updating the code if necessary.
 
 Setting up the development environment:
- * Install Python 3.8+
+ * Install Python 3.10+
  * Install the requirements
    ```bash
    $ python3 -m pip install -U pip

README.rst

@@ -16,13 +16,10 @@ breaking API changes.
 
 See also: https://neo4j.com/developer/kb/neo4j-supported-versions/
 
-+ Python 3.13 supported (since driver version 5.26.0).
-+ Python 3.12 supported (since driver version 5.14.0).
-+ Python 3.11 supported (since driver version 5.3.0).
++ Python 3.13 supported.
++ Python 3.12 supported.
++ Python 3.11 supported.
 + Python 3.10 supported.
-+ Python 3.9 supported.
-+ Python 3.8 supported.
-+ Python 3.7 supported.
 
 
 Installation

TESTING.md

@@ -1,6 +1,6 @@
 # Neo4j Driver Testing
 To run driver tests, [Tox](https://tox.readthedocs.io) is required as well as at least one version of Python.
-The versions of Python supported by this driver are CPython 3.7 - 3.12
+The versions of Python supported by this driver are CPython 3.10 - 3.13
 
 ## Testing with TestKit
 TestKit is the shared test suite used by all official (and some community contributed) Neo4j drivers to ensure consistent and correct behavior across all drivers.

benchkit/app.py

@@ -16,7 +16,6 @@
 
 from __future__ import annotations
 
-import sys
 import typing as t
 from contextlib import contextmanager
 from multiprocessing import Semaphore
@@ -44,10 +43,7 @@
     from .workloads import Workload
 
 
-if sys.version_info < (3, 8):
-    T_App: te.TypeAlias = "Sanic"
-else:
-    T_App: te.TypeAlias = "Sanic[Config, BenchKitContext]"
+T_App: te.TypeAlias = "Sanic[Config, BenchKitContext]"
 
 
 def create_app() -> T_App:

benchkit/workloads.py

@@ -20,12 +20,13 @@
 import enum
 import typing as t
 from dataclasses import dataclass
-from typing import Iterator
 
 import typing_extensions as te
 
 
 if t.TYPE_CHECKING:
+    from collections.abc import Iterator
+
     from neo4j import (
         AsyncDriver,
         AsyncManagedTransaction,

bin/make-unasync

@@ -113,6 +113,8 @@ class CustomRule(unasync.Rule):
         # it's not pretty, but it works
         # typing.Awaitable[...] -> typing.Union[...]
         self.token_replacements["Awaitable"] = "Union"
+        self.token_replacements["aiter"] = "iter"
+        self.token_replacements["anext"] = "next"
 
     def _unasync_tokens(self, tokens):
         # copy from unasync to fix handling of multiline strings
@@ -300,16 +302,15 @@ def apply_isort(paths):
 
 def apply_changes(paths):
     def files_equal(path1, path2):
-        with open(path1, "rb") as f1:
-            with open(path2, "rb") as f2:
+        with open(path1, "rb") as f1, open(path2, "rb") as f2:
+            data1 = f1.read(1024)
+            data2 = f2.read(1024)
+            while data1 or data2:
+                if data1 != data2:
+                    changed_paths[path1] = path2
+                    return False
                 data1 = f1.read(1024)
                 data2 = f2.read(1024)
-                while data1 or data2:
-                    if data1 != data2:
-                        changed_paths[path1] = path2
-                        return False
-                    data1 = f1.read(1024)
-                    data2 = f2.read(1024)
         return True
 
     changed_paths = {}

docs/README.md

@@ -2,7 +2,7 @@
 Sphinx Documentation
 ====================
 
-Building the docs requires Python 3.8+
+Building the docs requires Python 3.10+
 
 In project root
 ```

docs/source/async_api.rst

@@ -6,11 +6,6 @@ Async API Documentation
 
 .. versionadded:: 5.0
 
-.. warning::
-    There are known issue with Python 3.8 and the async driver where it
-    gradually slows down. Generally, it's recommended to use the latest
-    supported version of Python for best performance, stability, and security.
-
 ******************
 AsyncGraphDatabase
 ******************

docs/source/index.rst

@@ -18,13 +18,10 @@ See https://neo4j.com/developer/kb/neo4j-supported-versions/ for a driver-server
 
 Python versions supported:
 
-* Python 3.13 (added in driver version 5.26.0)
-* Python 3.12 (added in driver version 5.14.0)
-* Python 3.11 (added in driver version 5.3.0)
+* Python 3.13
+* Python 3.12
+* Python 3.11
 * Python 3.10
-* Python 3.9
-* Python 3.8
-* Python 3.7
 
 
 ******