TypeError when passing Query to Transaction.run (#1171)

Raise `TypeError` instead of `ValueError` when passing a `Query` object to
`Transaction.run`.

Author: robsdedude

CHANGELOG.md

@@ -40,6 +40,7 @@ See also https://github.com/neo4j/neo4j-python-driver/wiki for a full changelog.
   - `connection_acquisition_timeout` configuration option
     - `ValueError` on invalid values (instead of `ClientError`)
     - Consistently restrict the value to be strictly positive
+  - `TypeError` instead of `ValueError` when passing a `Query` object to `Transaction.run`.
   - `TransactionError` (subclass of `DriverError`) instead of `ClientError` (subclass of `Neo4jError`) when calling
     `session.run()` while an explicit transaction is active on that session.
     - This improves the differentiation between `DriverError` for client-side errors and `Neo4jError` for server-side

src/neo4j/_async/work/transaction.py

@@ -173,8 +173,7 @@ async def run(
         :returns: a new :class:`neo4j.AsyncResult` object
         """
         if isinstance(query, Query):
-            # TODO: 6.0 - make this a TypeError and remove lint exception
-            raise ValueError("Query object is only supported for session.run")  # noqa: TRY004
+            raise TypeError("Query object is only supported for session.run")
 
         if self._closed_flag:
             raise TransactionError(self, "Transaction closed")

src/neo4j/_sync/work/transaction.py

@@ -141,7 +141,7 @@ async def test_transaction_run_takes_no_query_object(async_fake_connection):
     tx = AsyncTransaction(
         async_fake_connection, 2, None, on_closed, on_error, on_cancel, None
     )
-    with pytest.raises(ValueError):
+    with pytest.raises(TypeError):
         await tx.run(Query("RETURN 1"))