Add more temporal types to the testkit-backend

Author: bigmontz

packages/testkit-backend/src/cypher-native-binders.js

@@ -115,6 +115,42 @@ function valueResponseOfObject (x) {
       }
     }
   }
+
+  if (neo4j.isDate(x)) {
+    return structResponse('CypherDate', {
+      year: x.year,
+      month: x.month,
+      day: x.day
+    })
+  } else if (neo4j.isDateTime(x) || neo4j.isLocalDateTime(x)) {
+    return structResponse('CypherDateTime', {
+      year: x.year,
+      month: x.month,
+      day: x.day,
+      hour: x.hour,
+      minute: x.minute,
+      second: x.second,
+      nanosecond: x.nanosecond,
+      utc_offset_s: x.timeZoneOffsetSeconds,
+      timezone_id: x.timeZoneId
+    })
+  } else if (neo4j.isTime(x) || neo4j.isLocalTime(x)) {
+    return structResponse('CypherTime', {
+      hour: x.hour,
+      minute: x.minute,
+      second: x.second,
+      nanosecond: x.nanosecond,
+      utc_offset_s: x.timeZoneOffsetSeconds
+    })
+  } else if (neo4j.isDuration(x)) {
+    return structResponse('CypherDuration', {
+      months: x.months,
+      days: x.days,
+      seconds: x.seconds,
+      nanoseconds: x.nanoseconds
+    })
+  }
+
   // If all failed, interpret as a map
   const map = {}
   for (const [key, value] of Object.entries(x)) {
@@ -123,6 +159,16 @@ function valueResponseOfObject (x) {
   return valueResponse('CypherMap', map)
 }
 
+function structResponse (name, data) {
+  const map = {}
+  for (const [key, value] of Object.entries(data)) {
+    map[key] = typeof value === 'bigint' || neo4j.isInt(value)
+      ? neo4j.int(value).toNumber()
+      : value
+  }
+  return { name, data: map }
+}
+
 export function cypherToNative (c) {
   const {
     name,
@@ -142,6 +188,17 @@ export function cypherToNative (c) {
     case 'CypherList':
       return data.value.map(cypherToNative)
     case 'CypherDateTime':
+      if (data.utc_offset_s == null && data.timezone_id == null) {
+        return new neo4j.LocalDateTime(
+          data.year,
+          data.month,
+          data.day,
+          data.hour,
+          data.minute,
+          data.second,
+          data.nanosecond
+        )
+      }
       return new neo4j.DateTime(
         data.year,
         data.month,
@@ -153,6 +210,35 @@ export function cypherToNative (c) {
         data.utc_offset_s,
         data.timezone_id
       )
+    case 'CypherTime':
+      if (data.utc_offset_s == null) {
+        return new neo4j.LocalTime(
+          data.hour,
+          data.minute,
+          data.second,
+          data.nanosecond
+        )
+      }
+      return new neo4j.Time(
+        data.hour,
+        data.minute,
+        data.second,
+        data.nanosecond,
+        data.utc_offset_s
+      )
+    case 'CypherDate':
+      return new neo4j.Date(
+        data.year,
+        data.month,
+        data.day
+      )
+    case 'CypherDuration':
+      return new neo4j.Duration(
+        data.months,
+        data.days,
+        data.seconds,
+        data.nanoseconds
+      )
     case 'CypherMap':
       return Object.entries(data.value).reduce((acc, [key, val]) => {
         acc[key] = cypherToNative(val)

packages/testkit-backend/src/skipped-tests/common.js

@@ -1,6 +1,10 @@
 import skip, { ifEquals, ifEndsWith } from './skip'
 
 const skippedTests = [
+  skip(
+    'Using numbers out of bound',
+    ifEquals('neo4j.datatypes.test_temporal_types.TestDataTypes.test_should_echo_temporal_type')
+  ),
   skip(
     'Testkit implemenation is deprecated',
     ifEquals('stub.basic_query.test_basic_query.TestBasicQuery.test_5x0_populates_node_only_element_id'),