Fix timezone offset calculation

Author: bigmontz

packages/bolt-connection/src/bolt/bolt-protocol-v5x0.utc.transformer.js

@@ -167,8 +167,7 @@ function getTimeInZoneId (timeZoneId, epochSecond, nano) {
     hour: 'numeric',
     minute: 'numeric',
     second: 'numeric',
-    hour12: false,
-    timeZoneName: 'short'
+    hour12: false
   })
 
   const l = epochSecondAndNanoToLocalDateTime(epochSecond, nano)
@@ -184,29 +183,23 @@ function getTimeInZoneId (timeZoneId, epochSecond, nano) {
   const formattedUtcParts = formatter.formatToParts(utc)
 
   const localDateTime = formattedUtcParts.reduce((obj, currentValue) => {
-    if (currentValue.type === 'timeZoneName') {
-      const parts = currentValue.value.replace('GMT', '').split(':')
-      const divisor = 60
-      const { offset } = parts.reduce((state, value) => {
-        const part = int(value)
-        const signal = part.isPositive() ? int(1) : int(-1)
-
-        const offset = part.multiply(state.factor).add(state.offset)
-        const factor = state.factor.div(divisor).multiply(signal)
-
-        return {
-          offset,
-          factor
-        }
-      }, { factor: int(60 * 60), offset: int(0) })
-
-      obj.timeZoneOffsetSeconds = offset
-    } else if (currentValue.type !== 'literal') {
+    if (currentValue.type !== 'literal') {
       obj[currentValue.type] = int(currentValue.value)
     }
     return obj
   }, {})
 
+  const epochInTimeZone = localDateTimeToEpochSecond(
+    localDateTime.year,
+    localDateTime.month,
+    localDateTime.day,
+    localDateTime.hour,
+    localDateTime.minute,
+    localDateTime.second,
+    localDateTime.nanosecond
+  )
+
+  localDateTime.timeZoneOffsetSeconds = epochInTimeZone.subtract(epochSecond)
   localDateTime.hour = localDateTime.hour.modulo(24)
 
   return localDateTime

packages/bolt-connection/test/bolt/bolt-protocol-v5x0.test.js

@@ -412,6 +412,10 @@ describe('#unit BoltProtocolV5x0', () => {
         'DateTimeWithZoneOffset',
         new DateTime(2022, 6, 14, 15, 21, 18, 183_000_000, 120 * 60)
       ],
+      [
+        'DateTimeWithZoneOffset / 1978',
+        new DateTime(1978, 12, 16, 10, 5, 59, 128000987, -150 * 60)
+      ],
       [
         'DateTimeWithZoneId / Berlin 2:30 CET',
         new DateTime(2022, 10, 30, 2, 30, 0, 183_000_000, 2 * 60 * 60, 'Europe/Berlin')
@@ -515,6 +519,14 @@ describe('#unit BoltProtocolV5x0', () => {
       [
         'DateTimeWithZoneId / Sao Paulo just 1 after turn winter time',
         new DateTime(2019, 2, 18, 1, 0, 0, 183_000_000, undefined, 'America/Sao_Paulo')
+      ],
+      [
+        'DateTimeWithZoneId / Istanbul',
+        new DateTime(1978, 12, 16, 12, 35, 59, 128000987, undefined, 'Europe/Istanbul')
+      ],
+      [
+        'DateTimeWithZoneId / Istanbul',
+        new DateTime(2020, 6, 15, 4, 30, 0, 183_000_000, undefined, 'Pacific/Honolulu')
       ]
     ])('should pack and unpack DateTimeWithZoneId and without offset (%s)', (_, object) => {
       const buffer = alloc(256)
@@ -824,6 +836,13 @@ describe('#unit BoltProtocolV5x0', () => {
         ]),
         new DateTime(2022, 6, 14, 15, 21, 18, 183_000_000, 120 * 60)
       ],
+      [
+        'DateTimeWithZoneOffset / 1978',
+        new structure.Structure(0x49, [
+          282659759, 128000987, -150 * 60
+        ]),
+        new DateTime(1978, 12, 16, 10, 5, 59, 128000987, -150 * 60)
+      ],
       [
         'DateTimeWithZoneId',
         new structure.Structure(0x69, [
@@ -837,6 +856,13 @@ describe('#unit BoltProtocolV5x0', () => {
           1655212878, 183_000_000, 'Australia/Eucla'
         ]),
         new DateTime(2022, 6, 14, 22, 6, 18, 183_000_000, 8 * 60 * 60 + 45 * 60, 'Australia/Eucla')
+      ],
+      [
+        'DateTimeWithZoneId / Honolulu',
+        new structure.Structure(0x69, [
+          1592231400, 183_000_000, 'Pacific/Honolulu'
+        ]),
+        new DateTime(2020, 6, 15, 4, 30, 0, 183_000_000, -10 * 60 * 60, 'Pacific/Honolulu')
       ]
     ])('should unpack spatial types and temporal types (%s)', (_, struct, object) => {
       const buffer = alloc(256)