Migrate to 2023.2.3 inspection engine (#1494)

Author: injectives

driver/src/main/java/org/neo4j/driver/Result.java

@@ -36,7 +36,6 @@
  * Results are valid until the next query is run or until the end of the current transaction,
  * whichever comes first. To keep a result around while further queries are run, or to use a result outside the scope
  * of the current transaction, see {@link #list()}.
- *
  * <h2>Important note on semantics</h2>
  *
  * In order to handle very large results, and to minimize memory overhead and maximize

driver/src/main/java/org/neo4j/driver/Session.java

@@ -260,7 +260,6 @@ default void executeWriteWithoutResult(Consumer<TransactionContext> contextConsu
      * This version of run takes a {@link Map} of parameters. The values in the map
      * must be values that can be converted to Neo4j types. See {@link Values#parameters(Object...)} for
      * a list of allowed types.
-     *
      * <h4>Example</h4>
      * <pre>
      * {@code

driver/src/main/java/org/neo4j/driver/SimpleQueryRunner.java

@@ -22,7 +22,6 @@
 
 /**
  * Common interface for components that can execute Neo4j queries.
- *
  * <h2>Important notes on semantics</h2>
  * <p>
  * queries run in the same {@link QueryRunner} are guaranteed to execute in order, meaning changes made by one query will be seen by all subsequent queries in
@@ -64,7 +63,6 @@ public interface SimpleQueryRunner {
      * send it back as parameters.
      * <p>
      * If you are creating parameters programmatically, {@link #run(String, Map)} might be more helpful, it converts your map to a {@link Value} for you.
-     *
      * <h4>Example</h4>
      * <pre class="doctest:QueryRunnerDocIT#parameterTest">
      * {@code
@@ -88,7 +86,6 @@ public interface SimpleQueryRunner {
      * <p>
      * This version of run takes a {@link Map} of parameters. The values in the map must be values that can be converted to Neo4j types. See {@link
      * Values#parameters(Object...)} for a list of allowed types.
-     *
      * <h4>Example</h4>
      * <pre class="doctest:QueryRunnerDocIT#parameterTest">
      * {@code

driver/src/main/java/org/neo4j/driver/Value.java

@@ -53,7 +53,6 @@
  * The second set of methods perform coercions to Java types (wherever possible).
  * For example, a common String value should be tested for using <code>isString</code>
  * and extracted using <code>stringValue</code>.
- *
  * <h2>Navigating a tree structure</h2>
  *
  * Because Neo4j often handles dynamic structures, this interface is designed to help

driver/src/main/java/org/neo4j/driver/async/AsyncQueryRunner.java

@@ -30,7 +30,6 @@
 
 /**
  * Asynchronous interface for components that can execute Neo4j queries.
- *
  * <h2>Important notes on semantics</h2>
  * <p>
  * Queries run in the same {@link AsyncQueryRunner} are guaranteed
@@ -62,7 +61,6 @@
  * While these semantics introduce some complexity, it gives the driver the ability
  * to handle infinite result streams (like subscribing to events), significantly lowers
  * the memory overhead for your application and improves performance.
- *
  * <h2>Asynchronous API</h2>
  * <p>
  * All overloads of {@link #runAsync(Query)} execute queries in async fashion and return {@link CompletionStage} of

driver/src/main/java/org/neo4j/driver/internal/async/connection/EventLoopGroupFactory.java

@@ -114,6 +114,7 @@ private static class DriverThreadFactory extends DefaultThreadFactory {
             super(THREAD_NAME_PREFIX, THREAD_IS_DAEMON, THREAD_PRIORITY);
         }
 
+        @SuppressWarnings("InstantiatingAThreadWithDefaultRunMethod")
         @Override
         protected Thread newThread(Runnable r, String name) {
             return new DriverThread(threadGroup, r, name);

driver/src/main/java/org/neo4j/driver/internal/cluster/ClusterRoutingTable.java

@@ -37,8 +37,6 @@
 import org.neo4j.driver.internal.DatabaseName;
 
 public class ClusterRoutingTable implements RoutingTable {
-    private static final int MIN_ROUTERS = 1;
-
     private final ReadWriteLock tableLock = new ReentrantReadWriteLock();
     private final DatabaseName databaseName;
     private final Clock clock;
@@ -66,9 +64,9 @@ public boolean isStaleFor(AccessMode mode) {
         return executeWithLock(
                 tableLock.readLock(),
                 () -> expirationTimestamp < clock.millis()
-                        || routers.size() < MIN_ROUTERS
-                        || mode == AccessMode.READ && readers.size() == 0
-                        || mode == AccessMode.WRITE && writers.size() == 0);
+                        || routers.isEmpty()
+                        || mode == AccessMode.READ && readers.isEmpty()
+                        || mode == AccessMode.WRITE && writers.isEmpty());
     }
 
     @Override

driver/src/main/java/org/neo4j/driver/internal/handlers/pulln/BasicPullResponseHandler.java

@@ -286,7 +286,7 @@ protected void state(State state) {
         this.state = state;
     }
 
-    enum State {
+    protected enum State {
         READY_STATE {
             @Override
             void onSuccess(BasicPullResponseHandler context, Map<String, Value> metadata) {

driver/src/main/java/org/neo4j/driver/internal/messaging/common/CommonValuePacker.java

@@ -96,7 +96,7 @@ public final void pack(Value value) throws IOException {
 
     @Override
     public final void pack(Map<String, Value> map) throws IOException {
-        if (map == null || map.size() == 0) {
+        if (map == null || map.isEmpty()) {
             packer.packMapHeader(0);
             return;
         }

driver/src/main/java/org/neo4j/driver/internal/messaging/request/HelloMessage.java

@@ -94,17 +94,7 @@ private static Map<String, Value> buildMetadata(
             result.put(USER_AGENT_METADATA_KEY, value(userAgent));
         }
         if (boltAgent != null) {
-            var boltAgentMap = new HashMap<String, String>();
-            boltAgentMap.put(BOLT_AGENT_PRODUCT_KEY, boltAgent.product());
-            if (boltAgent.platform() != null) {
-                boltAgentMap.put(BOLT_AGENT_PLATFORM_KEY, boltAgent.platform());
-            }
-            if (boltAgent.language() != null) {
-                boltAgentMap.put(BOLT_AGENT_LANGUAGE_KEY, boltAgent.language());
-            }
-            if (boltAgent.languageDetails() != null) {
-                boltAgentMap.put(BOLT_AGENT_LANGUAGE_DETAIL_KEY, boltAgent.languageDetails());
-            }
+            var boltAgentMap = toMap(boltAgent);
             result.put(BOLT_AGENT_METADATA_KEY, value(boltAgentMap));
         }
         if (routingContext != null) {
@@ -116,4 +106,19 @@ private static Map<String, Value> buildMetadata(
         MessageWithMetadata.appendNotificationConfig(result, notificationConfig);
         return result;
     }
+
+    private static HashMap<String, String> toMap(BoltAgent boltAgent) {
+        var boltAgentMap = new HashMap<String, String>();
+        boltAgentMap.put(BOLT_AGENT_PRODUCT_KEY, boltAgent.product());
+        if (boltAgent.platform() != null) {
+            boltAgentMap.put(BOLT_AGENT_PLATFORM_KEY, boltAgent.platform());
+        }
+        if (boltAgent.language() != null) {
+            boltAgentMap.put(BOLT_AGENT_LANGUAGE_KEY, boltAgent.language());
+        }
+        if (boltAgent.languageDetails() != null) {
+            boltAgentMap.put(BOLT_AGENT_LANGUAGE_DETAIL_KEY, boltAgent.languageDetails());
+        }
+        return boltAgentMap;
+    }
 }