Added tests and removed unused internal methods to improve test coverage.

Author: jakewins

driver/src/main/java/org/neo4j/driver/v1/GraphDatabase.java

@@ -34,7 +34,7 @@ public class GraphDatabase
      */
     public static Driver driver( String url )
     {
-        return driver( URI.create( url ) );
+        return driver( url, Config.defaultConfig() );
     }
 
     /**

driver/src/main/java/org/neo4j/driver/v1/Records.java

@@ -25,11 +25,6 @@
  */
 public abstract class Records
 {
-    private Records()
-    {
-        throw new UnsupportedOperationException();
-    }
-
     public static Function<RecordAccessor, Record> recordAsIs()
     {
         return RECORD;

driver/src/main/java/org/neo4j/driver/v1/exceptions/DatabaseException.java

@@ -24,11 +24,6 @@
  */
 public class DatabaseException extends Neo4jException
 {
-    public DatabaseException( String message )
-    {
-        super( message );
-    }
-
     public DatabaseException( String code, String message )
     {
         super( code, message );

driver/src/main/java/org/neo4j/driver/v1/exceptions/TransientException.java

@@ -24,11 +24,6 @@
  */
 public class TransientException extends Neo4jException
 {
-    public TransientException( String message )
-    {
-        super( message );
-    }
-
     public TransientException( String code, String message )
     {
         super( code, message );

driver/src/test/java/org/neo4j/driver/internal/ConfigTest.java

@@ -18,14 +18,16 @@
  */
 package org.neo4j.driver.internal;
 
-import java.io.File;
-
 import org.junit.Test;
 
+import java.io.File;
+
 import org.neo4j.driver.v1.Config;
 
+import static org.hamcrest.CoreMatchers.equalTo;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertThat;
 import static org.junit.Assert.assertTrue;
 
 public class ConfigTest
@@ -76,6 +78,16 @@ public void shouldChangeToTrustedCert()
         assertEquals( trustedCert.getAbsolutePath(), authConfig.certFile().getAbsolutePath() );
     }
 
+    @Test
+    public void shouldConfigureMinIdleTime() throws Throwable
+    {
+        // when
+        Config config = Config.build().withMinIdleTimeBeforeConnectionTest( 1337 ).toConfig();
+
+        // then
+        assertThat( config.idleTimeBeforeConnectionTest(), equalTo( 1337l ));
+    }
+
     public static void deleteDefaultKnownCertFileIfExists()
     {
         if( DEFAULT_KNOWN_CERTS.exists() )

driver/src/test/java/org/neo4j/driver/internal/ValuesTest.java

@@ -18,17 +18,17 @@
  */
 package org.neo4j.driver.internal;
 
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
 
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ExpectedException;
-
 import org.neo4j.driver.internal.value.ListValue;
 import org.neo4j.driver.internal.value.MapValue;
 import org.neo4j.driver.internal.value.StringValue;
@@ -40,7 +40,6 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotEquals;
-
 import static org.neo4j.driver.v1.Values.value;
 import static org.neo4j.driver.v1.Values.valueAsList;
 import static org.neo4j.driver.v1.Values.valueToString;
@@ -160,4 +159,34 @@ public void shouldMapDriverMapsToJavaMaps() throws Throwable
         assertThat( result.get( "Dog" ), equalTo( "2" ) );
         assertThat( result.get( "Cat" ), equalTo( "1" ) );
     }
+
+    @Test
+    public void shouldNotBeAbleToGetKeysFromNonKeyedValue() throws Throwable
+    {
+        // expect
+        exception.expect( ClientException.class );
+
+        // when
+        value( "asd" ).get(1);
+    }
+
+    @Test
+    public void shouldNotBeAbleToDoCrazyCoercions() throws Throwable
+    {
+        // expect
+        exception.expect( ClientException.class );
+
+        // when
+        value(1).asPath();
+    }
+
+    @Test
+    public void shouldNotBeAbleToGetSizeOnNonSizedValues() throws Throwable
+    {
+        // expect
+        exception.expect( ClientException.class );
+
+        // when
+        value(1).size();
+    }
 }

driver/src/test/java/org/neo4j/driver/internal/pool/InternalConnectionPoolTest.java

@@ -18,21 +18,20 @@
  */
 package org.neo4j.driver.internal.pool;
 
-import java.net.URI;
-import java.util.Collections;
-
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
 
+import java.net.URI;
+import java.util.Collections;
+
 import org.neo4j.driver.internal.spi.Connection;
 import org.neo4j.driver.internal.spi.Connector;
 import org.neo4j.driver.internal.util.Clock;
 import org.neo4j.driver.v1.Config;
 import org.neo4j.driver.v1.exceptions.ClientException;
 
 import static java.util.Collections.singletonList;
-
 import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
@@ -47,10 +46,9 @@ public class InternalConnectionPoolTest
     public ExpectedException exception = ExpectedException.none();
 
     @Test
-    public void shouldThrowExceptionWhenConnectionPoolIsFullWhatever() throws Throwable
+    public void shouldThrowExceptionWhenConnectionPoolIsFull() throws Throwable
     {
         // Given
-
         URI uri = URI.create( "bolt://asd" );
         Connector connector = connector( "bolt" );
         Config config = Config.build().withConnectionPoolSize( 1 ).toConfig();