Bump pre-commit tool versions +++ now requiring Python 3.8+ +++ (#631)

Co-authored-by: Robsdedude <[email protected]>

Author: MaxAake

.pre-commit-config.yaml

@@ -2,7 +2,7 @@
 # See https://pre-commit.com/hooks.html for more hooks
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.0.1
+    rev: v4.6.0
     hooks:
       - id: check-case-conflict
       - id: check-docstring-first
@@ -29,6 +29,6 @@ repos:
           - flake8-quotes
           - pep8-naming
   - repo: https://github.com/pycqa/isort
-    rev: 5.12.0
+    rev: 5.13.2
     hooks:
       - id: isort

CONTRIBUTING.md

@@ -2,7 +2,7 @@ Contributing
 ============
 
 Setting up the development environment:
- * Install Python 3.7+
+ * Install Python 3.8+
  * Install the requirements
    ```bash
    $ python3 -m pip install -U pip

boltstub/channel.py

@@ -146,7 +146,7 @@ def assert_no_input(self):
         if not no_input:
             try:
                 msg = self.peek()
-            except BaseException:
+            except Exception:
                 msg = (
                     "some data (encountered error while trying to peek):\n"
                     f"{traceback.format_exc()}"

boltstub/parsing.py

@@ -366,7 +366,7 @@ def _field_match(cls, should, is_):
             return type(is_) in should.types
         if isinstance(is_, Structure):
             return is_ == should
-        if type(should) != type(is_):
+        if type(should) is not type(is_):
             return False
         if isinstance(should, (list, tuple)):
             if len(should) != len(is_):

boltstub/simple_jolt/v1/codec.py

@@ -416,7 +416,7 @@ def _decode_full(value, decode_cb):
             raise JOLTValueError("Node id must be int")
         if not isinstance(labels, list):
             raise JOLTValueError("Node labels must be list")
-        if not all(map(lambda l: isinstance(l, str), labels)):
+        if not all(map(lambda label: isinstance(label, str), labels)):
             raise JOLTValueError("Node labels must be list of str")
         if not isinstance(properties, dict):
             raise JOLTValueError("Node properties must be dict")

boltstub/simple_jolt/v2/codec.py

@@ -110,7 +110,7 @@ def _decode_full(value, decode_cb):
             raise JOLTValueError("Node id must be int or none")
         if not isinstance(labels, list):
             raise JOLTValueError("Node labels must be list")
-        if not all(map(lambda l: isinstance(l, str), labels)):
+        if not all(map(lambda label: isinstance(label, str), labels)):
             raise JOLTValueError("Node labels must be list of str")
         if not isinstance(properties, dict):
             raise JOLTValueError("Node properties must be dict")
@@ -140,7 +140,7 @@ def _decode_full(cls, value, decode_cb):
         if not isinstance(value, list) or len(value) != 8:
             raise JOLTValueError('Expecting list of length 8 after sigil "%s"'
                                  % cls.sigil)
-        id_, start_node_id, rel_type, end_node_id, properties, element_id,\
+        id_, start_node_id, rel_type, end_node_id, properties, element_id, \
             start_node_element_id, end_node_element_id = value
 
         if not isinstance(id_, int) and id_ is not None:

boltstub/tests/test_integration.py

@@ -117,7 +117,7 @@ def __init__(self, script, address):
     def run(self):
         try:
             self.service.start()
-        except BaseException as e:
+        except Exception as e:
             traceback.print_exc()
             self.exc = e