fix: fx.Invoke for smr.Run not wrapped in Goroutine properly (#129)

Author: nekomeowww

.github/workflows/ci.yml

@@ -113,7 +113,8 @@ jobs:
       - name: golangci-lint
         uses: golangci/[email protected]
         with:
-          timeout: 10m
+          # Optional: golangci-lint command line arguments.
+          args: '--timeout=10m'
 
   unittest:
     name: Unit Test

.golangci.yml

@@ -11,7 +11,6 @@ linters:
 
     # - bodyclose # due to https://github.com/golangci/golangci-lint/issues/3086#issuecomment-1475232706
     - containedctx
-    - depguard
     - dupl
     - durationcheck
     - errname
@@ -40,6 +39,8 @@ linters:
     - usestdlibvars
     - whitespace
     - wsl
+  disable:
+    - depguard
 
 linters-settings:
   wsl:

cmd/insights-bot/main.go

@@ -2,7 +2,6 @@ package main
 
 import (
 	"context"
-	"github.com/nekomeowww/insights-bot/internal/services/smr"
 	"log"
 	"time"
 
@@ -19,6 +18,7 @@ import (
 	"github.com/nekomeowww/insights-bot/internal/services/autorecap"
 	"github.com/nekomeowww/insights-bot/internal/services/health"
 	"github.com/nekomeowww/insights-bot/internal/services/pprof"
+	"github.com/nekomeowww/insights-bot/internal/services/smr"
 	"github.com/nekomeowww/insights-bot/internal/thirdparty"
 )
 

internal/services/health/health.go

@@ -3,9 +3,6 @@ package health
 import (
 	"context"
 	"fmt"
-	"github.com/nekomeowww/insights-bot/internal/services/smr"
-	"github.com/nekomeowww/insights-bot/pkg/bots/discordbot"
-	"github.com/nekomeowww/insights-bot/pkg/bots/slackbot"
 	"net"
 	"net/http"
 	"time"
@@ -15,6 +12,9 @@ import (
 
 	"github.com/nekomeowww/insights-bot/internal/services/autorecap"
 	"github.com/nekomeowww/insights-bot/internal/services/pprof"
+	"github.com/nekomeowww/insights-bot/internal/services/smr"
+	"github.com/nekomeowww/insights-bot/pkg/bots/discordbot"
+	"github.com/nekomeowww/insights-bot/pkg/bots/slackbot"
 	"github.com/nekomeowww/insights-bot/pkg/bots/tgbot"
 	"github.com/nekomeowww/insights-bot/pkg/logger"
 )

internal/services/smr/smr.go

@@ -3,6 +3,8 @@ package smr
 import (
 	"context"
 	"errors"
+	"time"
+
 	"github.com/nekomeowww/insights-bot/internal/configs"
 	"github.com/nekomeowww/insights-bot/internal/datastore"
 	"github.com/nekomeowww/insights-bot/internal/models/smr"
@@ -14,7 +16,6 @@ import (
 	"github.com/redis/rueidis"
 	"github.com/samber/lo"
 	"go.uber.org/fx"
-	"time"
 )
 
 func NewModules() fx.Option {
@@ -151,9 +152,8 @@ func (s *Service) stop() {
 	s.closeFunc()
 }
 
-func Run() func(s *Service) error {
-	return func(s *Service) error {
-		s.run()
-		return nil
+func Run() func(s *Service) {
+	return func(s *Service) {
+		go s.run()
 	}
 }