Skip to content

Conversation

@navarr
Copy link
Owner

@navarr navarr commented Aug 2, 2018

Original Pull Request

magento#17127
By returning the storage.post promise, third party modules can perform
additional actions by adding .done/.fail or .always tasks to the request
promise by creating a Javascript mixin for the totals processor.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Magento CICD and others added 30 commits July 24, 2018 12:20
[2.3.0-Regression] MAGETWO-90995 Error on info:language:list call
 - merged latest code from mainline branch
 - Merge Pull Request magento#17080 from mage2pratik/magento2:fix-double-occurrence-2
 - Merged commits:
   1. 6a02ff6
   2. e8c3fec
   3. ab96cb3
…7107

 - Merge Pull Request magento#17107 from mage2pratik/magento2:code-cleanup-loginpost
 - Merged commits:
   1. 91074c4
 - Merge Pull Request magento#17106 from mage2pratik/magento2:2.3-develop-PR-port-16921
 - Merged commits:
   1. a993cf1
   2. 3ba9464
Accepted Public Pull Requests:
 - magento#17056: [Forwardport] Add generated code to the psr-0 autoloader section so when optimizing� (by @torhoehn)
 - magento#17049: [Forwardport] Log when Magento is in maintenance mode (by @torhoehn)
 - magento#17044: [Forwardport] Update nginx.config.sample to exclude php5-fpm (by @torhoehn)
 - magento#17054: [Forwardport] Remove extra spaces from Magento/Ui (by @torhoehn)
 - magento#17060: [Forwardport] fix: add hasrequired notice for create account form and password forg� (by @DanielRuf)
 - magento#17042: [Forwardport] Remove direct use of object manager (by @torhoehn)
 - magento#16956: [Forwardport] Trim issue on customer confirmation form (by @gelanivishal)
 - magento-engcom/import-export-improvements#117:  magento-engcom/import-export-improvements#103 Fail product import validation when multiselect columns contain duplicate values (by @pogster)
 - magento#17043: [Forwardport] Add Clean Code (by @torhoehn)
 - magento#17046: [Forwardport] Remove duplicated string. (by @torhoehn)


Fixed GitHub Issues:
 - magento#6058: IE11 user login email validation fails if field has leading or trailing space (reported by @dnadle) has been fixed in magento#16956 by @gelanivishal in 2.3-develop branch
   Related commits:
     1. f3502da
     2. 9d15ecc
     3. 6897f27

 - magento#103: Phoenix/Moneybookers (reported by @riconeitzel) has been fixed in magento-engcom/import-export-improvements#117 by @pogster in 2.3-develop branch
   Related commits:
     1. a765ec7
     2. d45e4f8
…#17028

 - Merge Pull Request magento#17028 from chirag-wagento/magento2:2.3-develop-PR-port-17019
 - Merged commits:
   1. 742df86
…tree's 'Pay with PayPal' button magento#15133 magento#15482

 - Merge Pull Request magento#15482 from vovayatsyuk/magento2:2.3-fix-braintree-outdated-address
 - Merged commits:
   1. 2d9734d
Stanislav Idolov and others added 28 commits August 1, 2018 07:58
 - merged latest code from mainline branch
…ndexer so the value isn't s… magento#17117

 - Merge Pull Request magento#17117 from chirag-wagento/magento2:2.3-develop-PR-port-15010
 - Merged commits:
   1. 661311d
   2. 9496635
Accepted Public Pull Requests:
 - magento#17293: Fixed a couple of typos (by @dverkade)
 - magento#17209: [Forwardport] Resolved : Mobile device style groups incorrect order (by @torhoehn)
 - magento#17201: [Forwardport] Update template.js (by @mage2pratik)
 - magento#17206: [Forwardport] Remove spaces around amount span. (by @torhoehn)
 - magento#17198: [Forwardport] Disable autocomplete for captcha inputs (by @mage2pratik)
 - magento#17228: Fix minor css issues (by @arnoudhgz)
 - magento#17266: [Forwardport] Replaced deprecated methods. (by @mageprince)


Fixed GitHub Issues:
 - magento#14476: Mobile device style groups incorrect order in _responsive.less (reported by @damiandawber) has been fixed in magento#17209 by @torhoehn in 2.3-develop branch
   Related commits:
     1. 647f2fa
[pangolin] Weekly regression enablement tests
[pangolin] MFTF 2.3.0 version update for CE 2.3
…test coverage & missed class property declaration. magento#17251
Accepted Public Pull Requests:
 - magento#17117: [Forwardport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s� (by @chirag-wagento)
 - magento#16856: [Forwardport] Fixed widget template rendering issue while rewriting widget block. (by @gelanivishal)
 - magento#17251: Forwardport 2.3 Maintenance: Compare products. Add unit test coverage & missed class property declaration. (by @swnsma)
 - magento#17268: [fix] license in composer (by @mhauri)
 - magento#17261: [Forwardport] magento#16273: Fix bug in method getUrlInStore() of product model (by @mage2pratik)
 - magento#17210: [Forwardport] Issue 8131 - Use Redirect Factory to Allow Error Message Display on Advanced Search (by @torhoehn)
 - magento#17051: [Forwardport] removed _responsive.less import from gallery.less (by @torhoehn)


Fixed GitHub Issues:
 - magento#16529: Rewriting product listing widget block breaks its template rendering. (reported by @sanganinamrata) has been fixed in magento#16856 by @gelanivishal in 2.3-develop branch
   Related commits:
     1. b519270
     2. 9197c68

 - magento#17225: License should reflect OSL (reported by @fooman) has been fixed in magento#17268 by @mhauri in 2.3-develop branch
   Related commits:
     1. 90134ae
     2. 0d5cb1e

 - magento#16273: Method $product->getUrlInStore() returning extremely long URLs, could be a bug (reported by @adampmoss) has been fixed in magento#17261 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. d116454
     2. 3a39a16
     3. 16ae409
     4. 4dc6aba

 - magento#8131: Magento 2.1.3 - There is a bug in advanced search form regarding validation messages (reported by @DarkLanternMG) has been fixed in magento#17210 by @torhoehn in 2.3-develop branch
   Related commits:
     1. 369b7bc
     2. 20a7124
     3. a39c8e4
by returning the storage.post promise, third party modules can perform
additional actions by adding .done/.fail or .always tasks to the request
promise by creating a Javascript mixin for the totals processor.
@navarr navarr closed this Aug 3, 2018
@navarr navarr deleted the 2.3-develop-PR-port-17127 branch December 12, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.