Skip to content

Conversation

@Lpsd
Copy link
Member

@Lpsd Lpsd commented Mar 4, 2025

Whilst there are many improvements and new features in lunasvg, this PR simply updates the version from 2.3.8 to 3.2.0

We can probably make use of some new features in another PR, see release history since 2.3.8: https://github.com/sammycage/lunasvg/releases

#4041 also needs merging after this

I've attached a test resource which creates a bunch of SVGs, and allows you to manipulate them.

Start the resource, use j and k to select elements prev/next (hand icon shows currently selected element). Use F1 to randomly reposition current element, F2 to randomly resize. Use F3 to spawn a new random SVG shape.

Resource: svg.zip

@Lpsd Lpsd changed the title Update from lunasvg 2.38 to 3.2.0 Update from lunasvg 2.3.8 to 3.2.0 Mar 4, 2025
@Dutchman101
Copy link
Member

Dutchman101 commented Mar 5, 2025

Is there any reason to believe that this is unlike any other vendor updates (when it comes to expected stability)? Asking you, @Lpsd as you're most familiar with the SVG implementation.

Because if there's not, it can just be merged as-is and tested in a practical setting; nightlies. At this point, the test resource passes, after all.

@Lpsd
Copy link
Member Author

Lpsd commented Mar 5, 2025

@Dutchman101 the existing behaviour should be unchanged, and if anything it will hopefully be a little faster at generation due to optimized code since the last version. It also includes support for some previously missing SVG features, and improved support for existing ones

From the release of 3.0:

The API for rendering and rasterization—the core of what LunaSVG is most often used for—remains mostly unchanged. However, there have been significant updates to the API for document manipulation.

We'll probably want to add support for the improved document manipulation in another PR, which will make it easier for people to update their SVG data.

@Dutchman101
Copy link
Member

Ok, thanks! Then we merge it now, as we're in the process of vendor updates at large, which this is meant to be part of.

@Dutchman101 Dutchman101 merged commit e7c59fb into multitheftauto:master Mar 5, 2025
6 checks passed
MTABot pushed a commit that referenced this pull request Mar 5, 2025
e7c59fb Update from lunasvg 2.3.8 to 3.2.0 (#4067)
708f50a Bump build
@Dutchman101 Dutchman101 added this to the 1.6.1 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants