Skip to content

Conversation

@Nico8340
Copy link
Member

Fixes unexpected ped sync behavior after #3936

@Nico8340
Copy link
Member Author

cc @tederis

@tederis tederis added bugfix Solution to a bug of any kind backwards-incompatible Should be merged after the release of 1.7.1 labels Jan 18, 2025
@tederis
Copy link
Member

tederis commented Jan 18, 2025

This is potentially backwards incompatible. But due to the bit flags overlapping it may be hard to distinguish whether it pre-PR or post-PR behaviour. I think this could be merged without noticable issues.

See the explanation in Discord: https://discord.com/channels/801330706252038164/801411628600000522/1330055415760818208

@Nico8340 Nico8340 requested a review from tederis January 18, 2025 20:48
@Nico8340
Copy link
Member Author

Could we get more maintainers' opinions on this?

@botder
Copy link
Member

botder commented Jan 26, 2025

We could also just ignore the issue and live with the overlap and simply get rid of the BitStream-versioned blocks with the next version bump

@Nico8340
Copy link
Member Author

We could also just ignore the issue and live with the overlap and simply get rid of the BitStream-versioned blocks with the next version bump

Okay, let's close this then?

@botder
Copy link
Member

botder commented Jan 26, 2025

Fine by me.

@Nico8340 Nico8340 closed this Jan 26, 2025
@Nico8340 Nico8340 deleted the pedsync branch January 26, 2025 16:51
@tederis
Copy link
Member

tederis commented Jan 27, 2025

The problem with it is that without this PR the ped syncronization becomes unstable which potentially can (but depends on internal BitStream implementation) lead to crashes.

@FileEX FileEX mentioned this pull request Aug 18, 2025
@Nico8340 Nico8340 restored the pedsync branch August 20, 2025 21:39
@Nico8340 Nico8340 reopened this Aug 20, 2025
@Nico8340 Nico8340 closed this Aug 20, 2025
@Nico8340 Nico8340 deleted the pedsync branch August 20, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompatible Should be merged after the release of 1.7.1 bugfix Solution to a bug of any kind

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants