Fix #1440 Driveby aiming is inverted in some cases #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qaisjp
suggested changes
May 15, 2020
Contributor
qaisjp
left a comment
qaisjp
left a comment
There was a problem hiding this comment.
The nested ifs are a bit intense - please can you use return where possible?
ghost
changed the title
ghost
reviewed
May 17, 2020
ghost
reviewed
May 17, 2020
Contributor
Author
|
I've tested it again after the commits. |
qaisjp
approved these changes
May 21, 2020
Contributor
qaisjp
left a comment
qaisjp
left a comment
There was a problem hiding this comment.
Refactor looks good. Force pushed to keep the bugfix and the refactor in distinct commits, so that we can do a rebase-merge or a merge commit.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by inverting fGunDirectionY if doing driveby and aiming left or behind.
Fixes #1440