Fix #1436: getValidPedModels() to include engineRequestModel skins as well

[Pirulax]

Okay, so in theory this fixes #1436 just fine.

Another way couldve been to just do this:

    for (int i = 0; i <= MAX_MODEL_ID; i++)
    {
        if (CClientPlayerManager::IsValidModel(i))
        {
            lua_pushnumber(luaVM, ++iIndex);
            lua_pushnumber(luaVM, i);
            lua_settable(luaVM, -3);
        }
    }

but i felt like that would have way bigger overhead than doing it this way. But correct me if im wrong.

[PlatinMTA]

As a hotfix maybe you want it to go until ID 5389, because that is the last allocable skin for peds. It will skip like 1500 loops so i guess it's worth it

[Pirulax]

As a hotfix maybe you want it to go until ID 5389, because that is the last allocateable skin for peds. It will skip like 1500 loops so i guess it's worth it

Are you a 100 percent sure? Another approach would be to just:

std::vector<std::vector<CClientModel*>> m_modelsByType;

or an std::map, for the first one. But Im not sure if thats necessary. To be quite honest, that seems overcomplicated to me, because nobody uses this function in render(if so, then they're plain stupid).

[sbx320]

Looks good to me, just a few minor comments. Another alternative would be to only track added models (and hardcode the rest), but that'd be fragile and prone to future breakage if other model types are added.

[Pirulax]

Oh god, im so stupid at git, please help 🤣

error: pathspec 'MTASA.sln.lnk' did not match any file(s) known to git

while trying to run:
git commit *.* -m "made changes as suggested by sbx"

Update: Ive googled around a bit more, and found out about -a. Now it works 😅

git commit -a -m "made changes as suggested by sbx"

[Pirulax]

Is this fine as it is?

My professional test method was:

local testCount = 100;

local requesteds = {}
for i = 1, testCount do
    requesteds[engineRequestModel("ped")] = true;
end

local found = 0;
for _, id in pairs(getValidPedModels()) do
    if (requesteds[id]) then 
        found = found + 1
     end
end
assert(found == testCount, "oh shit... here we go again!")

[Pirulax]

Issues:

• Because of the way engineFreeModel works ID's arent actually unreferenced (Removed) in the model manager, which causes this function to return free-d Ids
• Perhaps just add a new function: engineGetModelsByType as suggested by @qaisjp