Clean up SaveXML loop

Lpsd · Lpsd · commit fc46a28dd217 · 2019-08-17T17:44:20.000+01:00
diff --git a/Client/mods/deathmatch/logic/lua/CLuaMain.cpp b/Client/mods/deathmatch/logic/lua/CLuaMain.cpp
@@ -403,10 +403,8 @@ bool CLuaMain::DestroyXML(CXMLNode* pRootNode)
 
 bool CLuaMain::SaveXML(CXMLNode* pRootNode)
 {
-    list<CXMLFile*>::iterator iter;
-    for (iter = m_XMLFiles.begin(); iter != m_XMLFiles.end(); iter++)
+    for (CXMLFile* file : m_XMLFiles)
     {
-        CXMLFile* file = (*iter);
         if (file)
         {
             if (file->GetRootNode() == pRootNode)
diff --git a/Server/mods/deathmatch/logic/lua/CLuaMain.cpp b/Server/mods/deathmatch/logic/lua/CLuaMain.cpp
@@ -458,10 +458,8 @@ bool CLuaMain::DestroyXML(CXMLNode* pRootNode)
 
 bool CLuaMain::SaveXML(CXMLNode* pRootNode)
 {
-    list<CXMLFile*>::iterator iter;
-    for (iter = m_XMLFiles.begin(); iter != m_XMLFiles.end(); ++iter)
+    for (CXMLFile* file : m_XMLFiles)
     {
-        CXMLFile* file = (*iter);
         if (file)
         {
             if (file->GetRootNode() == pRootNode)

Original file line number	Diff line number	Diff line change
`@@ -403,10 +403,8 @@ bool CLuaMain::DestroyXML(CXMLNode* pRootNode)`
`403`	`403`
`404`	`404`	`bool CLuaMain::SaveXML(CXMLNode* pRootNode)`
`405`	`405`	`{`
`406`		`- list<CXMLFile*>::iterator iter;`
`407`		`- for (iter = m_XMLFiles.begin(); iter != m_XMLFiles.end(); iter++)`
	`406`	`+ for (CXMLFile* file : m_XMLFiles)`
`408`	`407`	`{`
`409`		`- CXMLFile* file = (*iter);`
`410`	`408`	`if (file)`
`411`	`409`	`{`
`412`	`410`	`if (file->GetRootNode() == pRootNode)`
Original file line number	Diff line number	Diff line change
`@@ -458,10 +458,8 @@ bool CLuaMain::DestroyXML(CXMLNode* pRootNode)`
`458`	`458`
`459`	`459`	`bool CLuaMain::SaveXML(CXMLNode* pRootNode)`
`460`	`460`	`{`
`461`		`- list<CXMLFile*>::iterator iter;`
`462`		`- for (iter = m_XMLFiles.begin(); iter != m_XMLFiles.end(); ++iter)`
	`461`	`+ for (CXMLFile* file : m_XMLFiles)`
`463`	`462`	`{`
`464`		`- CXMLFile* file = (*iter);`
`465`	`463`	`if (file)`
`466`	`464`	`{`
`467`	`465`	`if (file->GetRootNode() == pRootNode)`