Synchronize changes from 1.6 branch [ci skip]

feae02e Minor audio related changes
d68171c Fix heap corruption crash (No dialog) @ GTA SA 0x4fc66f: Engine sound type 4: Accelerate or type 5/Gear change
5c0c283 Addendum to 651cea5
e75b073 Fix audio crash

Author: github-actions[bot]

Client/core/CrashHandler.cpp

@@ -708,31 +708,21 @@ void __cdecl AbortSignalHandler([[maybe_unused]] int signal) noexcept
     CONTEXT*           pCtx = nullptr;
     EXCEPTION_POINTERS exPtrs{};
 
-    if (BuildExceptionContext(exPtrs, pExRecord, pCtx, EXCEPTION_NONCONTINUABLE_EXCEPTION))
+    PFNCHFILTFN callback = g_pfnCrashCallback.load(std::memory_order_acquire);
+
+    if (callback != nullptr && BuildExceptionContext(exPtrs, pExRecord, pCtx, EXCEPTION_NONCONTINUABLE_EXCEPTION))
     {
-        PFNCHFILTFN callback = g_pfnCrashCallback.load(std::memory_order_acquire);
-        if (callback != nullptr)
-        {
-            LogHandlerEvent(DEBUG_PREFIX_PURECALL, "Calling crash handler callback");
+        LogHandlerEvent(DEBUG_PREFIX_PURECALL, "Calling crash handler callback");
 
-            try
-            {
-                callback(&exPtrs);
-            }
-            catch (...)
-            {
-                LogHandlerEvent(DEBUG_PREFIX_PURECALL, "Exception in crash handler callback");
-            }
+        try
+        {
+            callback(&exPtrs);
         }
-        else
+        catch (...)
         {
-            LogHandlerEvent(DEBUG_PREFIX_PURECALL, "No crash handler callback available");
+            LogHandlerEvent(DEBUG_PREFIX_PURECALL, "Exception in crash handler callback");
         }
     }
-    else
-    {
-        LogHandlerEvent(DEBUG_PREFIX_PURECALL, "Failed to allocate exception structures");
-    }
 
     if (pCtx != nullptr)
     {
@@ -1346,7 +1336,7 @@ static bool BuildExceptionContext(EXCEPTION_POINTERS& outExPtrs, EXCEPTION_RECOR
 
     PFNCHFILTFN callback = g_pfnCrashCallback.load(std::memory_order_acquire);
 
-    if (BuildExceptionContext(exPtrs, pExRecord, pCtx, CPP_EXCEPTION_CODE) && callback != nullptr)
+    if (callback != nullptr && BuildExceptionContext(exPtrs, pExRecord, pCtx, CPP_EXCEPTION_CODE))
     {
         SafeDebugOutput(DEBUG_PREFIX_CPP "Calling crash handler callback\n");
 

Client/mods/deathmatch/logic/CClientSound.cpp

@@ -59,15 +59,14 @@ void CClientSound::AdoptBuffer(void* pMemory, unsigned int uiLength, AudioBuffer
         return;
     }
 
-    if (!m_Buffer || m_Buffer.get() != pMemory)
+    // Always release the old buffer before adopting a new one, even if the pointer is the same
+    // This prevents deleter mismatch issues (e.g., mixing new[]/delete[] with malloc/free)
+    if (m_Buffer)
     {
-        m_Buffer = BufferPtr(pMemory, std::move(deleter));
-    }
-    else
-    {
-        m_Buffer.get_deleter() = std::move(deleter);
+        ReleaseBuffer();
     }
 
+    m_Buffer = BufferPtr(pMemory, std::move(deleter));
     m_uiBufferLength = uiLength;
     m_strPath.clear();
 }
@@ -155,7 +154,7 @@ bool CClientSound::Create()
     // Load file/start connect
     if (!m_pAudio->BeginLoadingMedia())
     {
-        delete m_pAudio;
+        m_pAudio->Destroy();
         m_pAudio = nullptr;
         return false;
     }

Client/mods/deathmatch/logic/CClientSound.h

@@ -127,7 +127,7 @@ class CClientSound final : public CClientEntity
         static AudioBufferDeleter ForExternalReference() noexcept { return AudioBufferDeleter(&NoopImpl); }
 
     private:
-        static void DeleteArrayImpl(void* ptr) noexcept { ::operator delete[](ptr); }
+        static void DeleteArrayImpl(void* ptr) noexcept { delete[] static_cast<uint8_t*>(ptr); }
         static void FreeImpl(void* ptr) noexcept { std::free(ptr); }
         static void NoopImpl(void*) noexcept {}
 

Client/mods/deathmatch/logic/CClientSoundManager.cpp

@@ -141,6 +141,7 @@ CClientSound* CClientSoundManager::PlaySound2D(const SString& strSound, bool bIs
         memcpy(pMemory, strSound.data(), size);
         if (pSound->Play((void*)pMemory, size, bLoop))
             return pSound;
+        // Note: pMemory is already owned by pSound via AdoptBuffer, don't delete it here
     }
     else if (pSound->Play(strSound, bLoop))
         return pSound;
@@ -180,6 +181,7 @@ CClientSound* CClientSoundManager::PlaySound3D(const SString& strSound, bool bIs
             pSound->SetPosition(vecPosition);
             return pSound;
         }
+        // Note: pMemory is already owned by pSound via AdoptBuffer, don't delete it here
     }
     else if (pSound->Play3D(strSound, bLoop))
     {